Huawei driver: Failed to delete volume or snapshot if volume id or snapshot id is 0

Bug #1160340 reported by zhangchao on 2013-03-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Undecided
zhangchao
Grizzly
Undecided
John Griffith

Bug Description

Need to change the code "if volume_id:" to be "if volume_id is not None" in delete_volume. Because volume id may be 0.
The same to delete_snapshot.

zhangchao (zhangchao010) on 2013-03-26
Changed in cinder:
assignee: nobody → zhangchao (zhangchao010)
zhangchao (zhangchao010) on 2013-03-26
Changed in cinder:
status: New → In Progress

Reviewed: https://review.openstack.org/25393
Committed: http://github.com/openstack/cinder/commit/a3848ed80d7306833a87b1f7cfa3f89b58ab744a
Submitter: Jenkins
Branch: master

commit a3848ed80d7306833a87b1f7cfa3f89b58ab744a
Author: zhangchao010 <email address hidden>
Date: Tue Mar 26 22:10:19 2013 +0800

    Change format of some judgments

    Because "not volume" will be True if volume id is 0.It can not
    distinguish 0 from None.The same to some other judgments where
    variable value may be 0.

    This patch also does the following changes:
    Deletes check storagepool in function _check_conf_file and adds
    check default iscsi target IP in function initialize_connection.
    Moves create host group from do_setup to initialize_connection.
    Changes _get_login_info to be _update_login_info.

    Fixes bug: 1160340
    Change-Id: I0434b587d57c783f10d5724c4c66aea5df0b32e5

Changed in cinder:
status: In Progress → Fix Committed
zhangchao (zhangchao010) on 2013-04-15
tags: added: grizzly-backport-potential
zhangchao (zhangchao010) on 2013-05-17
tags: removed: grizzly-backport-potential
Thierry Carrez (ttx) on 2013-05-29
Changed in cinder:
milestone: none → havana-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2013-10-17
Changed in cinder:
milestone: havana-1 → 2013.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers