reschedule_or_reraise in cinder.volume.manager eats exception on base LVM driver

[John Griffith]

In certain conditions the _reschedule_or_reraise method will eat the error message/exception from LVM create returning no free extents. The result is the command returns succesfully, a volume is created in the DB and listed as available.

In reality however no LVM was ever created, and the cinder-vol logs show a trace including the lvcreate failure.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/26096

[Edward Hope-Morley (hopem)]

The proposed fix only partially solves the problem since. It does prevent the volume from entering the 'available' state but I notice that the volume now stays in 'creating' state indefinitely. I presume we would want the volume to go to 'error' after a finite number of re-schedules?

[Liang Chen (cbjchen)]

Yeah, you are right. The proposed fix only addresses the issue directly mentioned in this bug.

The reason why it stays in 'creating' state is that the scheduler cannot graceful handle the reschedule request because of another bug in volume manager. And I have already logged a bug for this problem.

Please take a look at https://bugs.launchpad.net/cinder/+bug/1164857.

Thanks.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/26096
Committed: http://github.com/openstack/cinder/commit/b823de4370fb306de0416d8ec1c1a70ac224207c
Submitter: Jenkins
Branch: master

commit b823de4370fb306de0416d8ec1c1a70ac224207c
Author: Liang Chen <email address hidden>
Date: Thu Apr 4 23:39:54 2013 +0800

    leave re-scheduled volume status to creating

    A re-scheduled volume should not be exported and set to available

    Fixes bug #1159027

    Change-Id: Ie61d9132ce1bd6461d5e4d9836424ebf14100389

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/26621

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/26621
Committed: http://github.com/openstack/cinder/commit/59f11c9969200aada1fdcedb763c95fa8085181a
Submitter: Jenkins
Branch: stable/grizzly

commit 59f11c9969200aada1fdcedb763c95fa8085181a
Author: Liang Chen <email address hidden>
Date: Thu Apr 4 23:39:54 2013 +0800

    leave re-scheduled volume status to creating

    A re-scheduled volume should not be exported and set to available

    Fixes bug #1159027

    Change-Id: Ie61d9132ce1bd6461d5e4d9836424ebf14100389
    (cherry picked from commit b823de4370fb306de0416d8ec1c1a70ac224207c)