test_preattach_status_volume is invalid
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
Medium
|
Avishay Traeger |
Bug Description
test_preattach_
From the thread:
Michael Fork wrote:
> I did some digging, and it looks like a subsequent refactoring (
> https:/
> of the original commit (
> https:/
> modified the code path here but didn't retain the original purpose of this
> test (which was to ensure the "attaching" state was set with an instance
> UUID on the way to being "attached"). However, I don't know the right way
> to fix. Looking at attach_volume in cinder/
> the volume_update call right before attach)volume on the driver is called.
> This test needs to be inserted right after volume_update. How is that
> best done?
John Griffith wrote:
Thanks for following up on this, I tracked down the commit as you did and
started looking at things. What is interesting here though (and what
distracted me a bit) is the fact that if you run the individual test it
makes it's way through the manager code path and works as the test is
written. Same holds true if you run the entire file "test_volume".
It seems that something isn't getting cleaned up properly by another test
somewhere or an assumption was made when this test was written. I have not
figured out the root cause of the issue. This is one of my gripes about a
large percentage of the unit tests, they're a bit convoluted and don't
necessarily really test what one would expect them to.
I'll leave it up to you, if you'd like to disable that test we can log a
bug and note that it's expected to be a "unit test" issue and not an issue
in the code and I can revisit later.
Changed in cinder: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in cinder: | |
milestone: | none → havana-1 |
status: | Fix Committed → Fix Released |
Changed in cinder: | |
milestone: | havana-1 → 2013.2 |
I will try to figure this out.