etc/cinder/cinder.conf.sample is out of date

Bug #1050135 reported by Joe Gordon on 2012-09-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Critical
Avishay Traeger

Bug Description

etc/cinder/cinder.conf.sample is out of date

For example:

snapshot_same_host (used in cinder/volume/api) is not in the sample conf

Rongze Zhu (zrzhit) wrote :

Hi Joe Gordon, the snapshot_same_host flag was added in https://review.openstack.org/#/c/9761/ , but it was removed in https://review.openstack.org/#/c/12442/1 .

I think that there are some mistacks in https://review.openstack.org/#/c/12442/1

Joe Gordon (jogo) wrote :

$ git grep snapshot_same_host
cinder/volume/api.py:volume_host_opt = cfg.BoolOpt('snapshot_same_host',
cinder/volume/api.py: if snapshot_id and FLAGS.snapshot_same_host:

Also iscsi_helper is missing etc.

Rongze Zhu (zrzhit) wrote :

iscsi_helper also was removed in https://review.openstack.org/#/c/12442/1

Changed in cinder:
status: New → Triaged
importance: Undecided → Critical
milestone: none → folsom-rc1
Changed in cinder:
assignee: nobody → Avishay Traeger (avishay-il)
status: Triaged → In Progress

Reviewed: https://review.openstack.org/12785
Committed: http://github.com/openstack/cinder/commit/a130956e667da9d040f99de4edb0c0f72afde25d
Submitter: Jenkins
Branch: master

commit a130956e667da9d040f99de4edb0c0f72afde25d
Author: Avishay Traeger <email address hidden>
Date: Tue Sep 11 17:11:41 2012 +0300

    Fixes bug 1050135.

    Regenerate cinder.conf.sample and fix a couple related bugs.

    Change-Id: I3e472f9c69ad4888dc15f901f4bc7cd825fb5ba1

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-09-18
Changed in cinder:
status: Fix Committed → Fix Released
Mark McLoughlin (markmc) on 2012-09-20
no longer affects: nova
Thierry Carrez (ttx) on 2012-09-27
Changed in cinder:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers