get_sets in DesktopCouchStore takes in a list and returns a list of trophy

Bug #675715 reported by Manish Sinha (मनीष सिन्हा) on 2010-11-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cheers
Medium
Manish Sinha (मनीष सिन्हा)

Bug Description

As seen in line 78 of datastore.py file in method definition get_sets
http://bazaar.launchpad.net/~cheers/cheers/dev/annotate/head:/cheers/datastore.py#L78

method get_sets takes a list of ids? For what? The request is to get a list of all the sets available in cheers database

When None or [] is provided it returns back a list of Trophy instances which is not desirable. The only thing needed to be returned is set name. An array of set name (as)

Assigned to Seif as he was the person who implemented DesktopCouchStore

Changed in cheers:
assignee: nobody → Seif Lotfy (seif)
importance: Undecided → Medium
status: New → Confirmed
Changed in cheers:
milestone: none → 0.1.0
Changed in cheers:
assignee: Seif Lotfy (seif) → Manish Sinha (manishsinha)
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers