qt interface has no obvious exit after testing

[Jeff Lane ]

Testing something out using the latest checkbox trunk code. I have a whitelist that is running a bunch of bogus manual jobs that look like this:

plugin: manual
name: sniff/sniff1
description: sniffing, click Yes to continue

There's a white llist for these, as well as a local job to parse the job file.

However, after all is said and done, the qt interface presents me with the Submit Results or View Results buttons. I click Submit Results with no email address, and then the button is greyed out, but there is no button that says "Exit".

I don't think it's terribly obvious to a user to have to close the program using the window control (nor is it proper behaviour IMO). The final page needs a defined "Exit" button to make it clear that this is what you click to shut Checkbox down.

[Jeff Lane  (bladernr)]

Here's a screenshot showing this

[Jeff Lane  (bladernr)]

Really hope this gets resolved before release... checkbox doesn't close after clicking Submit Results, and never seems to cleanly exit. After running checkbox-qt many times to test various things, I'm left with several checkbox-qt-service processes left running because the only way to close checkbox seems to be the window control button.

bladernr@klaatu:~/development/967457-remove-warning$ ps axf |grep checkb
26973 pts/2 S+ 0:00 | \_ grep --color=auto checkb
 8907 ? Sl 0:00 /usr/share/checkbox/qt/checkbox-qt-service
 9744 ? Sl 0:00 /usr/share/checkbox/qt/checkbox-qt-service
 9802 ? Sl 0:00 /usr/share/checkbox/qt/checkbox-qt-service
23925 ? Sl 0:00 /usr/share/checkbox/qt/checkbox-qt-service
25348 ? Sl 0:00 /usr/share/checkbox/qt/checkbox-qt-service
26966 pts/2 Sl 0:00 ./checkbox-qt-service

[Brendan Donegan (brendan-donegan)]

I'm not sure I quite buy the need for a big exit button. Certainly I can't think of many applications that do have one. Usually the window close button is used, or perhaps the actual Exit option from the menu. I guess the difference is that Checkbox has a kind of 'workflow' so it might be expected to have an 'end' as such.

[Brendan Donegan (brendan-donegan)]

I guess the real question is whether we want to have a big 'Exit' button on the last screen? Also, should it be disabled until a submission is succesful?

[Ara Pulido (ara)]

This should be discussed before milestone it, as it is a personal opinion.

Let's discuss it, and see if it is worth making any changes.

In any case, I don't see this urgent enough for release.

[Jeff Lane  (bladernr)]

I think it's dependent on the type of application. For example, something like OOWriter doesn't need an exit button at the end because there is no end, but most games include an Exit menu option in the in-game menus because at some point you expect to quit playing and exit via the menu option (not by just closing the window).

As Brendan points out, Checkbox has a defined linear workflow with a start and a finish, and at the end there should be, IMO, so sort of mechanism to finalize this. To me, clicking Submit Results is not the "End" because there are times I run checkbox and I do NOT want to submit any results (and this is me as an Ubuntu user, not as a certification tester).

But either way, clicking submit results or no, there seems to be no offical "End" to checkbox. Now, in lieu of an exit button, which I would still prefer, perhaps just changing the message text to be more informative would suffice, something like "Please enter your email address associated with your LP account and click Submit Results to submit these test results to Ubuntu Friendly. When you are done, close this window."

[Jeff Lane  (bladernr)]

anyway, just wanted to jot down my thoughts on this before I forgot them

[Brendan Donegan (brendan-donegan)]

I think it's obvious the UI should be clearer as to what to do after submitting results - whether this entails having a big 'Exit' button is a personal opinion, but at the very least the text should be updated. Anyway I'm knocking down the priority of this a little bit as I don't think it really warrants a High

[Brendan Donegan (brendan-donegan)]

Ignore the last sentence, for some reason I read the importance as High