Ubuntu Friendly warning is wrong
Bug #967457 reported by
Ara Pulido
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox |
Fix Released
|
High
|
Jeff Lane | ||
Bug Description
In the submit results tab, if a user has not run all the tests, a warning stating that the submission won't make to Friendly appears.
This never goes away, unless the tester tests everything (not skipping).
We should only show it if the user does not finish all the tests they have selected.
WORKAROUND: Let's fix it by not showing the warning at all (never)
Related branches
lp:~bladernr/checkbox/967457-remove-warning
- Checkbox Developers: Pending requested
-
Diff: 70 lines (+13/-7)4 files modifieddebian/changelog (+7/-1)
qt/checkbox-qt.ui (+2/-2)
qt/frontend/qtfront.cpp (+1/-1)
qt/frontend/qtfront.ui (+3/-3)
lp:~roadmr/ubuntu/precise/checkbox/0.13.7
- Mathieu Trudel-Lapierre: Approve
-
Diff: 171775 lines (+80184/-40843)101 files modifiedcheckbox_qt/qt_interface.py (+18/-2)
debian/changelog (+38/-0)
debian/po/es.po (+9/-4)
jobs/local.txt.in (+8/-0)
jobs/mediacard.txt.in (+8/-8)
jobs/networking.txt.in (+2/-2)
jobs/optical.txt.in (+0/-3)
po/ace.po (+788/-406)
po/af.po (+788/-406)
po/am.po (+788/-406)
po/ar.po (+799/-410)
po/ast.po (+1158/-665)
po/az.po (+788/-406)
po/be.po (+840/-415)
po/bg.po (+827/-421)
po/bn.po (+889/-411)
po/bo.po (+820/-420)
po/br.po (+825/-419)
po/bs.po (+840/-415)
po/ca.po (+846/-422)
po/ca@valencia.po (+821/-415)
po/ckb.po (+788/-406)
po/cs.po (+1166/-440)
po/cy.po (+788/-406)
po/da.po (+852/-427)
po/de.po (+1260/-686)
po/dv.po (+788/-406)
po/el.po (+1215/-670)
po/en_AU.po (+1390/-877)
po/en_CA.po (+824/-418)
po/en_GB.po (+1377/-871)
po/eo.po (+819/-416)
po/es.po (+1261/-618)
po/et.po (+788/-406)
po/eu.po (+796/-407)
po/fa.po (+788/-406)
po/fi.po (+905/-681)
po/fr.po (+974/-501)
po/ga.po (+788/-406)
po/gd.po (+792/-410)
po/gl.po (+842/-420)
po/he.po (+868/-424)
po/hi.po (+818/-415)
po/hr.po (+823/-417)
po/hu.po (+848/-418)
po/hy.po (+788/-406)
po/id.po (+819/-419)
po/is.po (+792/-409)
po/it.po (+1197/-423)
po/ja.po (+863/-413)
po/jbo.po (+788/-406)
po/ka.po (+788/-406)
po/kk.po (+822/-416)
po/km.po (+788/-406)
po/kn.po (+788/-406)
po/ko.po (+843/-438)
po/ku.po (+788/-406)
po/ky.po (+788/-406)
po/lt.po (+823/-420)
po/lv.po (+830/-413)
po/mk.po (+788/-409)
po/ml.po (+788/-406)
po/mr.po (+788/-406)
po/ms.po (+1147/-649)
po/my.po (+788/-406)
po/nb.po (+831/-420)
po/nds.po (+788/-406)
po/ne.po (+792/-406)
po/nl.po (+1726/-629)
po/nn.po (+788/-406)
po/oc.po (+826/-414)
po/pl.po (+827/-444)
po/ps.po (+788/-406)
po/pt.po (+825/-419)
po/pt_BR.po (+1180/-620)
po/ro.po (+1199/-463)
po/ru.po (+1018/-682)
po/sd.po (+789/-407)
po/shn.po (+788/-406)
po/si.po (+788/-406)
po/sk.po (+820/-445)
po/sl.po (+1174/-485)
po/sq.po (+841/-416)
po/sr.po (+826/-411)
po/sv.po (+840/-418)
po/ta.po (+788/-406)
po/te.po (+788/-406)
po/th.po (+821/-418)
po/tr.po (+1220/-443)
po/ug.po (+1123/-652)
po/uk.po (+844/-443)
po/ur.po (+788/-406)
po/uz.po (+788/-406)
po/vi.po (+821/-415)
po/zh_CN.po (+820/-414)
po/zh_HK.po (+816/-413)
po/zh_TW.po (+834/-425)
qt/checkbox-qt.ui (+2/-2)
qt/frontend/qtfront.cpp (+8/-3)
qt/frontend/qtfront.h (+4/-2)
qt/frontend/qtfront.ui (+3/-3)
Revision history for this message
| Jeff Lane (bladernr) wrote Re: [Bug 967457] [NEW] Ubuntu Friendly warning is wrong | #1 |
| Changed in checkbox: | |
| milestone: | 0.13.x → 0.13.7 |
| importance: | Undecided → High |
| status: | New → Triaged |
| description: | updated |
| Changed in checkbox: | |
| assignee: | nobody → Jeff Lane (bladernr) |
| status: | Triaged → Fix Committed |
| Changed in checkbox: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I would think that the proper behaviour for the warning is to appear any
time selected tests are skipped. I know there's the case where the UF
whitelist lists a test that a user may not be able to run due to lack of
hardware (optical tests, for instance) but the point of it was to
discourage users selecting/
So if we fix it so the warning goes away if a user deselects tests from
the UF whitelist, there's little point in the warning to begin with, no?
At least IMO.
--
Jeff Lane - Hardware Certification Engineer and Test Tools Developer
Ubuntu Ham: W4KDH
Freenode IRC: bladernr or bladernr_
gpg: 1024D/3A14B2DD 8C88 B076 0DD7 B404 1417 C466 4ABD 3635 3A14 B2DD