wireless_connection tests pass even when the connection test failed
Bug #944176 reported by
Brendan Donegan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox |
Fix Released
|
Medium
|
Brendan Donegan |
Bug Description
Running the various wireless_connection tests results in the tests passing, even though the output given in the submission is something like:
Failed to activate ubuntu-
This is likely to be because the return code used to judge the test results is the last one here:
create_connection $WPA_BG_SSID --security=wpa --key=$WPA_BG_PSK; internet_test --interface=`nmcli dev status | awk '/802-11-wireless/ {print $1}'`; rm -f /etc/NetworkMan
that is the rm -rf command.
If internet_test fails then the whole test should fail.
Related branches
lp:~brendan-donegan/checkbox/bug944176_wireless_connection_failpass
- Daniel Manrique (community): Approve
- Marc Tardif (community): Needs Information
- Brendan Donegan (community): Needs Resubmitting
-
Diff: 69 lines (+8/-6)2 files modifieddebian/changelog (+2/-0)
jobs/wireless.txt.in (+6/-6)
lp:~javier.collado/ubuntu/precise/checkbox/0.13.4
- Daniel Holbach (community): Approve
-
Diff: 8665 lines (+4575/-636)21 files modifiedcheckbox/lib/process.py (+1/-1)
checkbox/parsers/udevadm.py (+5/-3)
debian/changelog (+62/-27)
debian/checkbox-gtk.install (+0/-1)
debian/control (+1/-1)
debian/po/cs.po (+119/-0)
debian/po/oc.po (+119/-0)
gtk/checkbox-gtk.desktop.in (+0/-11)
jobs/disk.txt.in (+6/-6)
jobs/local.txt.in (+114/-38)
jobs/wireless.txt.in (+6/-6)
plugins/backend_info.py (+2/-2)
po/POTFILES.in (+1/-1)
po/de.po (+158/-106)
po/nl.po (+263/-137)
po/ru.po (+129/-109)
po/sd.po (+2994/-0)
po/uk.po (+375/-121)
scripts/create_connection (+23/-8)
scripts/removable_storage_test (+196/-57)
setup.cfg (+1/-1)
Changed in checkbox: | |
assignee: | nobody → Brendan Donegan (brendan-donegan) |
status: | New → In Progress |
Changed in checkbox: | |
status: | In Progress → Fix Committed |
milestone: | none → 0.13.4 |
Changed in checkbox: | |
importance: | Undecided → Medium |
Changed in checkbox: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.