bluetooth/detect shouldn't run on a system with no Bluetooth device
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox |
Fix Released
|
Medium
|
Brendan Donegan | ||
checkbox (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Oneiric |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Running the latest oneiric, checkbox and checkbox-gtk from ppa:checkbox-dev checkbox_
I get to the bluetooth tests, and get a dialog box saying "bluetooth/detect crashed" I have no bluetooth hardware attached.
I try to submit a bug report but the process freezes and I can't carry on with the test run.
[Impact]
The bluetooth/detect test will run (and fail) on systems with no Bluetooth hardware.
On systems with apport enabled, this will pop up a crash report window, needlessly worrying the user.
On all systems, this will mistakenly report to Ubuntu Friendly that bluetooth hardware was present but failed, which penalizes the user's score for optional hardware that is not actually present. This means that a computer without bluetooth hardware is unable to get a perfect 5-star score in UF, which is misrepresentative of a system that may work perfectly but have no Bluetooth support.
[Development fix]
Checkbox revision 1114 changes the test definition so it requires an actual bluetooth device to run. Otherwise the test is marked as skipped due to unmet requirements, which is the correct behavior.
[Stable fix]
This is fixed in http://
[Test Case]
- Start "system testing" (checkbox-gtk version 0.12.8) on an 11.10 system with NO bluetooth hardware (check that output of hcitool dev shows no devices). As originally reported, a virtual machine may fulfill this requirement.
- Press "Next" and provide password when prompted.
- Press "Deselect all", then select "Bluetooth tests" and press Next.
Expected result:
- Bluetooth test doesn't run
- Test gets marked as skipped / requirements not met in the final report.
Actual result:
- Bluetooth test attempts to run, crashes, if apport is enabled the user will be requested to file a bug report.
- Test appears as failed in the final report.
[Regression potential]This actually reduces the pool of systems on which this test will run, and the added code simply checks that a bluetooth resource (essentially a string match against a text file) is present. Thus the potential for regression is almost nil. Maybe if a system has a bluetooth device that is not presented as such it will be untested now, but such a scenario is unlikely.
Related branches
- Daniel Manrique (community): Approve
-
Diff: 44 lines (+9/-3)2 files modifieddebian/changelog (+3/-0)
jobs/bluetooth.txt.in (+6/-3)
- Ubuntu Sponsors: Pending requested
-
Diff: 18858 lines (+9936/-3266)93 files modifiedcheckbox/application.py (+5/-5)
checkbox/contrib/persist.py (+5/-4)
checkbox/dispatcher.py (+201/-0)
checkbox/lib/bit.py (+5/-4)
checkbox/lib/config.py (+15/-2)
checkbox/lib/conversion.py (+131/-42)
checkbox/lib/dmi.py (+169/-18)
checkbox/lib/safe.py (+5/-0)
checkbox/lib/template.py (+1/-1)
checkbox/message.py (+4/-3)
checkbox/parsers/cpuinfo.py (+30/-41)
checkbox/parsers/cputable (+40/-0)
checkbox/parsers/cputable.py (+42/-0)
checkbox/parsers/deferred.py (+27/-0)
checkbox/parsers/dmidecode.py (+123/-0)
checkbox/parsers/meminfo.py (+46/-0)
checkbox/parsers/submission.py (+474/-383)
checkbox/parsers/udevadm.py (+178/-317)
checkbox_cli/cli_interface.py (+9/-1)
checkbox_gtk/gtk_interface.py (+4/-4)
data/whitelists/default.whitelist (+1/-0)
debian/changelog (+59/-0)
debian/po/ro.po (+118/-0)
examples/checkbox.ini (+1/-1)
gtk/checkbox-gtk.ui (+37/-37)
jobs/apport.txt.in (+0/-5)
jobs/audio.txt.in (+44/-24)
jobs/autotest.txt.in (+4/-2)
jobs/bluetooth.txt.in (+64/-52)
jobs/camera.txt.in (+19/-12)
jobs/codecs.txt.in (+16/-38)
jobs/cpu.txt.in (+3/-3)
jobs/daemons.txt.in (+11/-11)
jobs/disk.txt.in (+6/-5)
jobs/evolution.txt.in (+0/-26)
jobs/fingerprint.txt.in (+24/-20)
jobs/firewire.txt.in (+9/-8)
jobs/gcalctool.txt.in (+0/-52)
jobs/gedit.txt.in (+0/-22)
jobs/gnome-terminal.txt.in (+0/-12)
jobs/graphics.txt.in (+63/-51)
jobs/hibernate.txt.in (+9/-7)
jobs/info.txt.in (+47/-27)
jobs/input.txt.in (+15/-7)
jobs/install.txt.in (+1/-1)
jobs/keys.txt.in (+58/-45)
jobs/local.txt.in (+41/-6)
jobs/ltp.txt.in (+3/-2)
jobs/mago.txt.in (+4/-2)
jobs/mediacard.txt.in (+106/-84)
jobs/memory.txt.in (+8/-5)
jobs/miscellanea.txt.in (+19/-8)
jobs/monitor.txt.in (+43/-24)
jobs/networking.txt.in (+31/-32)
jobs/optical.txt.in (+56/-42)
jobs/panel_clock_test.txt.in (+18/-15)
jobs/panel_reboot.txt.in (+8/-6)
jobs/pcmcia-pcix.txt.in (+6/-3)
jobs/peripheral.txt.in (+27/-22)
jobs/phoronix.txt.in (+4/-2)
jobs/power-management.txt.in (+32/-18)
jobs/qa_regression.txt.in (+4/-2)
jobs/resource.txt.in (+15/-0)
jobs/screenshot.txt.in (+0/-13)
jobs/server-services.txt.in (+12/-12)
jobs/stress.txt.in (+18/-10)
jobs/suspend.txt.in (+52/-31)
jobs/usb.txt.in (+55/-36)
jobs/user_apps.txt.in (+337/-110)
jobs/wireless.txt.in (+9/-9)
plugins/apport_prompt.py (+1/-1)
plugins/launchpad_report.py (+6/-4)
plugins/persist_info.py (+2/-1)
plugins/resource_info.py (+14/-1)
plugins/system_info.py (+2/-2)
po/POTFILES.in (+0/-6)
po/ca@valencia.po (+2897/-0)
po/el.po (+229/-293)
po/en_GB.po (+240/-240)
po/gd.po (+2606/-0)
po/ja.po (+297/-335)
po/lt.po (+294/-357)
po/tr.po (+217/-177)
scripts/connect_wireless (+1/-1)
scripts/cpuinfo_resource (+13/-17)
scripts/dmi_resource (+55/-0)
scripts/hal_resource (+0/-5)
scripts/meminfo_resource (+15/-27)
scripts/package_resource (+6/-0)
scripts/udev_resource (+2/-2)
scripts/usb_test (+5/-3)
setup.cfg (+1/-7)
setup.py (+2/-0)
- Luke Yelavich (community): Approve
-
Diff: 279 lines (+82/-54)10 files modifiedcheckbox/contrib/persist.py (+5/-4)
checkbox/lib/safe.py (+5/-0)
checkbox/message.py (+4/-3)
checkbox_gtk/gtk_interface.py (+2/-4)
debian/changelog (+20/-0)
gtk/checkbox-gtk.ui (+37/-37)
jobs/input.txt.in (+1/-1)
plugins/persist_info.py (+2/-1)
scripts/connect_wireless (+1/-1)
scripts/usb_test (+5/-3)
summary: |
- bluetooth/detect crashes + bluetooth/detect shouldn't run on a system with no Bluetooth device |
Changed in checkbox: | |
status: | Triaged → Fix Committed |
assignee: | nobody → Brendan Donegan (brendan-donegan) |
milestone: | 0.13 → 0.12.9 |
Changed in checkbox: | |
status: | Fix Committed → Fix Released |
description: | updated |
description: | updated |
If i say that I don't want to submit a bug report, the run continues to the bluetooth file transfer test, even though I don't have the hardware.