mediacard after_suspend test depend on power-management/suspend_advanced instead of suspend/suspend_advanced

Bug #860651 reported by Brendan Donegan on 2011-09-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Medium
Jeff Lane

Bug Description

The dependencies for the mediacard tests are wrong. They depend on power-management/suspend_advanced which was the old name for suspend/suspend_advanced. They dependencies need to be changed so that they work properly and the after_suspend tests actually run after suspending the system.

Related branches

Changed in checkbox:
milestone: none → 0.12.8
assignee: nobody → Brendan Donegan (brendan-donegan)
status: New → In Progress
importance: Undecided → Medium

I corrected the dependencies but they still run one after the other. I need to investigate why this is and it might make fixing this a lot more tricky.

Changed in checkbox:
assignee: Brendan Donegan (brendan-donegan) → nobody
status: In Progress → Triaged
Jeff Lane (bladernr) wrote :

It appears that the dependencies only apply to suites...

Currently, mediacard.txt contains both mediacard/sd and mediacard/sd_after_suspend

These both run when checkbox runs the "mediacard" suite rather than picking and choosing.

So you can not hop from one suite to the next like this:

suspend/pre-test-1
suspend/pre-test-2
suspend/suspend_advanced
suspend/post-test1
mediacard/post-test2
suspend/post-test-3
someothersuite/post-test4

if I create a sd_after_suspend test in the suspend suite, however, then the new suspend/sd_after_suspend test IS held until after suspend/suspend_advanced is run, while mediacard/sd and mediacard/sd_after_suspend are both run BEFORE, but run at the same time (while mediacard is run).

I'm thinking that this is a limitation of checkbox's design and I'm thinking that this is not going to be fixed in time for oneiric.

Jeff Lane (bladernr) on 2011-09-28
Changed in checkbox:
assignee: nobody → Jeff Lane (bladernr)
status: Triaged → Fix Committed
Jeff Lane (bladernr) wrote :

Merge request is ONLY for renaming the dependencies to clean that up. bug #861218 directly affects this and could resolve the rest of the issues without making it necessary to move the jobs to the suspend.txt file...

though as the ONLY post-suspend jobs that are not part of suspend.txt are the media card ones, I'd be happier moving them anyway...

Jeff Lane (bladernr) wrote :

bug #861218 is now resolved. Tested this patch with Marc's patch from that bug and this is resolved as well.

Ara Pulido (ara) on 2011-09-30
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers