check minimum resolution not working
Bug #855599 reported by
Victor Tuson Palau
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox |
Fix Released
|
High
|
Brendan Donegan | ||
checkbox (Ubuntu) |
Fix Released
|
High
|
Unassigned |
Bug Description
I believe that this test checks that the current resolution is not lower that a minum res of 800x600. The test fail cause the following typo:
def compare_
# Evaluate just the primary display
screen = Gdk.Screen.
geom = screen.
return geom.width >= min_h and geom.height >= min_h
The return line is checking twice for the same number it should be
return geom.width >= min_h and geom.height >= min_v
Related branches
lp:~brendan-donegan/checkbox/fix_minimum_resolution
- Marc Tardif (community): Approve
-
Diff: 33 lines (+3/-3)2 files modifieddebian/changelog (+1/-0)
scripts/resolution_test (+2/-3)
lp:~roadmr/ubuntu/oneiric/checkbox/0.12.8
- Mathieu Trudel-Lapierre: Approve
- Ubuntu branches: Pending requested
-
Diff: 12410 lines (+2530/-1911)31 files modifiedcheckbox/job.py (+1/-1)
checkbox/lib/transport.py (+14/-4)
checkbox_gtk/gtk_interface.py (+5/-2)
data/whitelists/default.whitelist (+3/-14)
debian/changelog (+56/-0)
debian/po/de.po (+28/-16)
debian/po/it.po (+10/-9)
debian/po/pt_BR.po (+9/-7)
gtk/checkbox-gtk.desktop.in (+1/-1)
jobs/mediacard.txt.in (+6/-6)
jobs/miscellanea.txt.in (+2/-2)
jobs/suspend.txt.in (+3/-3)
plugins/apport_prompt.py (+2/-0)
plugins/intro_prompt.py (+14/-7)
plugins/launchpad_exchange.py (+6/-2)
plugins/suites_prompt.py (+4/-0)
po/de.po (+457/-301)
po/gl.po (+274/-301)
po/hu.po (+16/-16)
po/it.po (+36/-37)
po/pt_BR.po (+431/-339)
po/ru.po (+491/-321)
po/sl.po (+461/-227)
po/zh_HK.po (+126/-213)
scripts/connect_wireless (+4/-3)
scripts/cpu_scaling_test (+50/-9)
scripts/internet_test (+2/-2)
scripts/network_check (+3/-5)
scripts/reconnect (+0/-5)
scripts/resolution_test (+14/-57)
scripts/usb_test (+1/-1)
Changed in checkbox: | |
importance: | Undecided → High |
Changed in checkbox: | |
status: | New → Confirmed |
Changed in checkbox: | |
assignee: | nobody → Brendan (brendan) |
Changed in checkbox: | |
assignee: | Brendan (brendan) → Brendan Donegan (brendan-donegan) |
status: | Confirmed → In Progress |
Changed in checkbox: | |
status: | In Progress → Confirmed |
milestone: | none → 0.12.8 |
Changed in checkbox: | |
status: | In Progress → Fix Committed |
Changed in checkbox (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in checkbox: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Tsk, tsk - In progress is after Confirmed