stop-all event fired when failing to contact backend
Bug #719552 reported by
Marc Tardif
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox |
Fix Released
|
High
|
Marc Tardif |
Bug Description
When Checkbox fails to contact the backend through either fifo files, a SIGIO signal is raised. This causes the lock_prompt plugin to react and fire the stop-all event. The problem is that the plugin is only expecting that signal when the directory containing the lock file notifies of a deleted file. So, the same handler is being called in two different contexts.
The solution would be to define the signal handler in the lock_prompt plugin to be MULTISHOT and explicitly check for the existence of the lock file before firing the stop-all event.
Related branches
lp:~cr3/checkbox/719552
- Marc Tardif (community): Approve
-
Diff: 34 lines (+9/-2)2 files modifieddebian/changelog (+6/-0)
plugins/lock_prompt.py (+3/-2)
Changed in checkbox: | |
status: | New → In Progress |
importance: | Undecided → High |
assignee: | nobody → Marc Tardif (cr3) |
Changed in checkbox: | |
status: | In Progress → Fix Committed |
description: | updated |
Changed in checkbox: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.