in graphics-2d.txt graphics-2d and graphics-2d-output are the same test

Bug #671144 reported by Jeff Lane
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Brendan Donegan

Bug Description

both the graphics-2d and graphics-2d-output tests are identical. the second one is automated just to spit output into the logs. Thses should be replaced with a single test that does both. And really, does this even need to be seen by the user? Obviously X is running if they're running the checkbox UI and seeing the testcase... so this could be made simply fully automated instead.

Related branches

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

I'll do a 'fix' for this.

Changed in checkbox-compatibility:
importance: Undecided → Low
status: New → Triaged
assignee: nobody → Brendan Donegan (brendan-donegan)
Revision history for this message
Ara Pulido (ara) wrote :

What happened with this?

Changed in checkbox-compatibility:
status: Triaged → Incomplete
Revision history for this message
Daniel Manrique (roadmr) wrote :

I see the two related merge requests as pending and "needs information", but the changes are already in latest trunk, the test appears only once and has been renamed to graphics/xorg-version.

Since this is assigned to Brendan I'll mark as Triaged again, pending a decision on whether the current manual behavior is sufficient (in which case, please mark as Fix Released) or we will further automate this test.

My $0.02 is that we needn't confuse the user with versions, let's just confirm that X is running (xdpyinfo complains if that's not the case) and log the information. If xdpyinfo says "can't open display" it means that X is not running.

Changed in checkbox-compatibility:
status: Incomplete → Triaged
Revision history for this message
Jeff Lane (bladernr) wrote :

Moved to checkbox since the tests now reside there...

affects: checkbox-compatibility → checkbox-editor
affects: checkbox-editor → checkbox
visibility: private → public
Changed in checkbox:
status: Triaged → In Progress
Changed in checkbox:
status: In Progress → Fix Committed
Marc Tardif (cr3)
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers