fwts changes to the desktop certification whitelist

[Ara Pulido]

For 14.04, we will need these changes to the fwts test in desktop certification

(These changes are only for desktop, so, please, don't modify the default fwts test, we will just remove this one from the whitelists and create a new one).

1) Remove the fwts_test from the desktop whitelists
2) Create a new job called "firmware/fwts_desktop_diagnosis" that will be run as part of the desktop whitelists, but won't affect certification (log from running this job needs to be attached). This job won't pass or fail based on errors in the log, it will just attach the log to the submission. It will run the following fwts tests:

 - acpidump
 - version
 - acpitables
 - apicinstance
 - hpet_check
 - mcfg
 - method
 - mpcheck
 - msr
 - mtrr
 - apicedge
 - klog

3) Create a new job (under cpu) called cpu/cstates that runs the fwts cstates test. Fail on HIGH or CRITICAL as usual. Attach the log as usual. Add it to the whitelists.
4) Remove the S3,S4 checklog test from the whitelist, but keep attaching the S3/S4 logs
5) Create a new job called miscellanea/oops that runs the fwts oops test. Fail on HIGH or CRITICAL as usual. Attach the log as usual. Add it to the whitelists.
6) Create a new job called firmware/wakealarm that runs the fwts wakealarm test. Fail on HIGH or CRITICAL as usual. Attach the log as usual. Add it to the whitelists.
7) Create a new job called firmware/uefirtvariable that runs the fwts uefirtvariable test. Fail on HIGH or CRITICAL as usual. Attach the log as usual. Add it to the whitelists.

[Daniel Manrique (roadmr)]

Hi,

Can I change the test names?

We already have a local job that builds sub-tests for all fwts-supported tests, so items 3 and 5 would be simply additions to the whitelist, with no new test writing required. Actually, items 6 and 7 were implemented this way.

The difference vs. what was requested here is that the tests will be called firmware/cstates and firmware/oops, instead of cpu/cstates and miscellanea/oops.

I'll submit the MR with exactly what was requested here but leave it pending confirmation of whether it's OK to change the test names a bit.

[Ara Pulido (ara)]

Why would you like to change the names? cstates is a cpu test, and oops is a kernel test

[Daniel Manrique (roadmr)]

The local job that builds sub-tests puts them all under firmware/.*. If I want to put cstates under cpu and oops under miscellanea, I have to write them again, it duplicates a bit of work and loses a bit of the advantage of the generator job.

It's really up to you, if you prefer the names you requested the work is already done (see branch linked to this bug), doing it the other way would be a bit cleaner/shorter but at this point they're both almost equally easy to do