Clicking the test button results in ReferenceError: outcome is not defined

[Daniel Manrique]

file:///usr/share/checkbox-gui/qml/ManualInteractionDialog.qml:231: ReferenceError: outcome is not defined

This is on a trusty system with checkbox-ng packages at 0.1-1ubuntu1, plainbox at 0.4-4 and checkbox-gui at 0.17.6-0ubuntu1.

To reproduce, launch a job that requires the test button, then click "test".

We specifically tried something like:

plugin: manual
name: roadmr
command: echo "whee"; true
description: something

This exact job triggers the failure.

[Daniel Manrique (roadmr)]

I think this happened in this merge:

https://code.launchpad.net/~sylvain-pineau/checkbox/fix-1227684/+merge/202016

but I'm not sure :)

[Sylvain Pineau (sylvain-pineau)]

file:///usr/share/checkbox-gui/qml/ManualInteractionDialog.qml:231: ReferenceError: outcome is not defined

I simply forgot to adjust the name of the variable, it's no longer outcome but suggested_outcome line 231.

And please don't use Manual jobs with a command, that doesn't work, i.e. logs are not attached and the status not properly updated (from what I tested); prefer user-(interact|verify|interact-verify) instead.

[Daniel Manrique (roadmr)]

Fixed here:

https://code.launchpad.net/~brendan-donegan/checkbox/bug1287395/+merge/209288

As Sylvain mentioned, using plugin: manual makes things not work, maybe we should outright reject manual jobs with a command; if they don't work, it's pointless to accept them.

Other than making the error disappear, and correctly updating the outcome based on test output, this magically made graphical commands (such as zenity) work on my test system \o/

[Launchpad Janitor (janitor)]

This bug was fixed in the package checkbox - 0.17.6-0ubuntu2

---------------
checkbox (0.17.6-0ubuntu2) trusty; urgency=low

  [Sylvain Pineau]
  * Update the default whitelist selection check mark on startup (LP: #1287389)
  * Properly set the suggested outcome for user-interact type jobs. Due to a
    variable name change, the outcome wasn't getting set (LP: #1287395)
 -- Sylvain Pineau <email address hidden> Wed, 05 Mar 2014 15:34:29 +0100

[Zygmunt Krynicki (zyga)]

This doesn't seem to be actually fixed in Ubuntu. Because we cherry pick and squash fixes it's harder to see but nothing in the recent history in Ubuntu modifies the affected file