dvd_write test will pass without actually writing data to DVD

Bug #1131598 reported by Jeffrey Chang on 2013-02-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Undecided
Unassigned

Bug Description

checkbox 0.15.2~ppa+bzr1907+201302011726~precise1

When testing optical/dvd-write, checkbox quickly show pass after press test button.
Then I check the DVD disc, and found it was totally empty.

checkbox log has below message:
Now working in /tmp/optical-test ...
Getting sample files from /usr/share/example-content/ ...
Generating md5sums of sample files ...
Checking md5sums ...
How fast.ogg: OK
Josh Woodward - Swansong.ogg: OK
Creating ISO Image ...
Sleeping 10 seconds in case drive is not yet ready ...
Beginning image burn ...
Device type : Removable CD-ROM
Version : 5
Response Format: 2
Capabilities :
Vendor_info : 'hp '
Identification : 'CDDVDW SN-208BB '
Revision : 'HH05'
Device seems to be: Generic mmc2 DVD-R/DVD-RW.
Using generic SCSI-3/mmc DVD-R(W) driver (mmc_mdvd).
Driver flags : SWABAUDIO BURNFREE
Supported modes: PACKET SAO
Starting to write CD/DVD at speed 4.0 in real unknown mode for single session.
Last chance to quit, starting real write in 0 seconds. Operation starts.
Failed to burn ISO image
Attempting to clean up ...
Moving back to original location
Now residing in /home/user
Cleaning up ...
Ejecting spent media ...
, 18.672245979309082) for message-result with priority -100.

Related branches

Jeffrey Chang (modern911) wrote :

Manually test with Brasero to write data to DVD is ok.

Daniel Manrique (roadmr) wrote :

Hello!

The command for dvd-write is:

optical_write_test /dev/`ls /sys$path/block` | ansi_parser

The problem here is that the exit code will be that of ansi_parser, which is always true. So even if the optical_write_test fails, the result will be true (pass).

The solution as implemented in other jobs is to change the command to:

set -o pipefail; optical_write_test /dev/`ls /sys$path/block` | ansi_parser

This affects also cd-write, so that needs to be changed as well.

Changed in checkbox:
status: New → In Progress
Zygmunt Krynicki (zyga) on 2013-02-28
Changed in checkbox:
status: In Progress → Fix Committed
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers