network_device_info is too crude in categorising devices found by lspci

Bug #1091633 reported by Brendan Donegan on 2012-12-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Medium
Sylvain Pineau

Bug Description

network_device_info, as used by networking/detect, uses the very crude logic that if a device is displayed as 'Ethernet Controller' in lspci, then it is in fact an ethernet controller. Due to stupidity in some drivers, some wireless cards show as 'Ethernet Controller' and have an interface name of eth1 for example. The logic of the script should be expanded to use more definite criteria.

One possibility is to take advantage of the udev parser to find the network devices. This does a better job of categorising them already and is used by other parts of Checkbox

Related branches

Sylvain Pineau (sylvain-pineau) wrote :

Indeed the udev parser will give better results. We could even get rid of querying the Networkmanager interface with dbus.
But will still have to use modinfo to get the driver version (not returned by udev).

Sylvain Pineau (sylvain-pineau) wrote :

Triaged as we have a +1 to use udev!

Changed in checkbox:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Sylvain Pineau (sylvain-pineau)
Changed in checkbox:
status: In Progress → Fix Committed
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers