Wireless tests need to exit gracefully if they haven't been set up properly

Bug #1086734 reported by Ara Pulido
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox Provider - Base
Won't Fix
Low
Unassigned

Bug Description

Instead of giving just an usage error (when the user normally never uses create_connection, nor needs to know how the wireless tests are implemented), if the environment for the router ssid hasn't been properly set, it should fail gracefully and give a proper message.

This is the current error:

usage: create_connection [-h] [-S SECURITY] [-K KEY] [-U UUID] [-R RETRIES] [-I INTERVAL] ssid create_connection: error: too few arguments rm: cannot remove `/etc/NetworkManager/system-connections/': Is a directory

Tags: scripts
Ara Pulido (ara)
description: updated
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

We need to expand the command to do some validation. It's going to make it more convoluted, but if it helps people less familiar with Checkbox then I guess it's okay

Changed in checkbox:
status: New → Triaged
importance: Undecided → Medium
Changed in checkbox:
status: Triaged → In Progress
assignee: nobody → Brendan Donegan (brendan-donegan)
Revision history for this message
Daniel Manrique (roadmr) wrote :

This script no longer spits out the unfriendly error, but maybe should print a short help text explaining what it expects. Then again, the current output may be enough.

$ /usr/share/checkbox/scripts/create_connection
usage: create_connection [-h] [-U UUID] [-R RETRIES] [-I INTERVAL]
                         {wifi,mobilebroadband} ...
create_connection: error: too few arguments

tags: added: scripts
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

We don't get many complaints about this, so I'll put it at low importance and take it off my todo list.

Changed in checkbox:
importance: Medium → Low
status: In Progress → Triaged
assignee: Brendan Donegan (brendan-donegan) → nobody
Zygmunt Krynicki (zyga)
affects: checkbox → plainbox-provider-checkbox
Changed in plainbox-provider-checkbox:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.