networking/detect test crashed due to a traceback in modinfo_parser when the parser was passed apparently bad data
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox |
Fix Released
|
Medium
|
Jeff Lane |
Bug Description
Looking at some test results and networking/detect crashed. This caused a cascade failure where other networking tests failed to run, which also caused the suspend test to fail to run.
The test caused a traceback from modinfo_parser due to what I'm guessing is bad data passed from udev when network_device_info runs.
It could well be because the network card on this machine is not a common one, but I have to get more data from the tester to be sure. lspci on the machine says:
The traceback is:
Traceback (most recent call last):
File "/usr/share/
sys.
File "/usr/share/
nm_devices = get_nm_devices()
File "/usr/share/
devices.
File "/usr/share/
self._modinfo = self._modinfo_
File "/usr/share/
parser = ModinfoParser(
File "/usr/lib/
self.
File "/usr/lib/
key, data = line.split(':',1)
ValueError: need more than 1 value to unpack
Unfortunately, because this occurred, it caused checkbox to only record stderr, which only captured the trace. So I have no idea at the moment which device this is. I'm guessing it's the ethernet device for now.
I have asked the tester to manually run a modified version of the network_device_info script on that machine and see if the data it provides can help me fix this bug. At the moment, I do not know what data props['Driver'] is passing to modinfo parser. I have a feeling it's either nothing, or garbage.
Related branches
- Sylvain Pineau (community): Approve
-
Diff: 57 lines (+22/-13)2 files modifiedcheckbox/parsers/modinfo.py (+19/-12)
debian/changelog (+3/-1)
Changed in checkbox: | |
status: | New → Triaged |
importance: | Undecided → Medium |
importance: | Medium → High |
assignee: | nobody → Jeff Lane (bladernr) |
Changed in checkbox: | |
status: | Triaged → Fix Committed |
Changed in checkbox: | |
status: | Fix Committed → Fix Released |
The device appears in the results as
JMicron JMC250 PCI Express Gigabit Ethernet Controller