udev_resource does not identify s390 dasd as a DISK device
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox Support Library |
Fix Released
|
Critical
|
Jeff Lane | ||
Bug Description
Looking at some results from a zVM instances that has both scsi and dasd disk devices, I noticed that the dasd devices are not being labled as DISK and thus the tests are not being run on them.
Here's a block device resource dump from one:
ubuntu@hwe0008:~$ /usr/lib/
dasdc_state: internal
dasdc_usb2: unsupported
dasdc_usb3: unsupported
dasdc_rotation: no
dasdc_smart: False
dasda_state: internal
dasda_usb2: unsupported
dasda_usb3: unsupported
dasda_rotation: no
dasda_smart: False
dasdb_state: internal
dasdb_usb2: unsupported
dasdb_usb3: unsupported
dasdb_rotation: no
dasdb_smart: False
So it's seeing them fine, but here are the DISK items that udev_resource is providing:
ubuntu@hwe0008:~$ sudo /usr/lib/
path: /devices/
name: dasda
bus: ccw
driver: dasd-eckd
product: IBM s390 Virtual Disk
product_slug: IBM_s390_
path: /devices/
name: dasda1
bus: block
product: IBM s390 Virtual Disk
product_slug: IBM_s390_
path: /devices/
name: dasda2
bus: block
product: IBM s390 Virtual Disk
product_slug: IBM_s390_
path: /devices/
name: dasdb
bus: ccw
driver: dasd-eckd
product: IBM s390 Virtual Disk
product_slug: IBM_s390_
path: /devices/
name: dasdb1
bus: block
product: IBM s390 Virtual Disk
product_slug: IBM_s390_
path: /devices/
name: dasdc
bus: ccw
driver: dasd-eckd
product: IBM s390 Virtual Disk
product_slug: IBM_s390_
path: /devices/
name: dasdc1
bus: block
product: IBM s390 Virtual Disk
product_slug: IBM_s390_
path: /devices/
bus: net
category: NETWORK
driver: qeth
interface: enc600
mac: 02:28:0b:00:00:04
Not it does not provide a category for any of them...
Related branches
- Sylvain Pineau (community): Approve
-
Diff: 1504 lines (+1470/-0)4 files modifiedcheckbox_support/parsers/tests/test_udevadm.py (+5/-0)
checkbox_support/parsers/tests/udevadm_data/IBM_s390x_DASD.lsblk (+7/-0)
checkbox_support/parsers/tests/udevadm_data/IBM_s390x_DASD.txt (+1455/-0)
checkbox_support/parsers/udevadm.py (+3/-0)
- Jeff Lane : Needs Resubmitting
- Sylvain Pineau (community): Needs Fixing
- Jonathan Cave (community): Needs Fixing
-
Diff: 1513 lines (+1472/-0) (has conflicts)4 files modifiedcheckbox_support/parsers/tests/test_udevadm.py (+7/-0)
checkbox_support/parsers/tests/udevadm_data/IBM_s390x_DASD.lsblk (+7/-0)
checkbox_support/parsers/tests/udevadm_data/IBM_s390x_DASD.txt (+1455/-0)
checkbox_support/parsers/udevadm.py (+3/-0)
| Jeff Lane (bladernr) wrote | #1 |
| Changed in checkbox-support: | |
| status: | New → In Progress |
| importance: | Undecided → Critical |
| assignee: | nobody → Jeff Lane (bladernr) |
| Changed in plainbox-provider-resource: | |
| status: | In Progress → Invalid |
| no longer affects: | plainbox-provider-resource |
| Changed in checkbox-support: | |
| milestone: | none → 0.33.0 |
| Changed in checkbox-support: | |
| status: | In Progress → Fix Committed |
| Changed in checkbox-support: | |
| status: | Fix Committed → Fix Released |
Marked invalid for the resource provider as the fix was actually in the parser in checkbox-support.