merged submissions do not show the correct information (testplan_id, custom_joblist, rejected-jobs)

[Pierre Equoy]

checkbox-ng: 1.6.0

1. run checkbox-cli, select a test plan (e.g. 18.04 certification), select/deselect a few jobs in there, run the session
    → A session archive ~/.local/share/checkbox-ng/submission_xxx.tar.xz is generated
2. run:

cd ~/.local/share/checkbox-ng/
checkbox-cli merge-submissions -o merged.tar.xz submission_xxx.tar.xz submission_xxx.tar.xz

→ a merged.tar.xz archive is generated

3. Compare the submission.json from both merged.tar.xz and submission_xxx.tar.xz

Expected result: both files are identical.

Actual results:

- testplan_id is missing in merged.tar.xz
- custom_joblist is set to "true" in submission_xxx.tar.xz but it's set to "false" in merged.tar.xz
- rejected-jobs contains a list of jobs that have been deselected in submission_xxx.tar.xz but it's empty in merged.tar.xz

[Pierre Equoy (pieq)]

I've investigated this a bit while working on a webapp that makes use of parts of the code used by merge_submissions.py, and I came to the conclusion that the following is needed:

        manager.state.metadata.custom_joblist = self.custom_joblist
        manager.state.metadata.rejected_jobs = [j["full_id"] for j in self.rejected_jobs]
        blob = {'description': self.description,
                'testplan_id': self.testplan_id}
        self.update_app_blob(manager, json.dumps(blob).encode("UTF-8"))

I'll try to propose a patch for this soonish.

[Sylvain Pineau (sylvain-pineau)]

@Pierre, any update on this merge issue?

[Maksim Beliaev (beliaev-maksim)]

Bug was migrated to GitHub: https://github.com/canonical/checkbox/issues/144.
Bug is no more monitored here.