canonical-certification server and other -cli commands crash due to use of job.name rather than job.id
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Next Generation Checkbox (CLI) |
Fix Released
|
Critical
|
Daniel Manrique |
Bug Description
- Install a Trusty server system
- Add the ppa:checkbox-
- install checkbox-ng plainbox-
- run canonical-
- select the server-cert whitelist
Expected result:
- List of tests to run
Actual result:
File "/usr/lib/
line = prefix + self.depth * ' ' + ' ' + title
TypeError: Can't convert 'NoneType' object to str implicitly
This is because cli.py still has job.name instead of job.id in that line. Switching that to job.id makes it work (though it shows namespaced job names). It can also be job.partial_id, but job.name is just bad :)
$ grep -r 'job\.name' *
checkbox-
plainbox/
plainbox/
plainbox/
Related branches
- Zygmunt Krynicki (community): Approve
- Daniel Manrique (community): Needs Resubmitting
-
Diff: 95 lines (+23/-23)2 files modifiedcheckbox-ng/checkbox_ng/commands/cli.py (+1/-1)
checkbox-ng/checkbox_ng/commands/test_cli.py (+22/-22)
tags: | added: sru-candidate |
Changed in checkbox-ng: | |
status: | In Progress → Fix Committed |
milestone: | none → 0.3.2 |
Changed in checkbox-ng: | |
status: | Fix Committed → Fix Released |
Changed in checkbox-ng: | |
milestone: | 0.3.2 → none |
Critical because cli commands outright don't work if this bug is present.