cstat is obsolete, it does redundant work
Bug #1216955 reported by
Curtis Hovey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| charmworld |
Triaged
|
Medium
|
Unassigned | ||
Bug Description
Every 24 hours, cron runs charmworld/
update_
I don't believe this action provides valuable data because every cron calls charmworld/
update_
Surely the download counts for the charm are current when cstat.py is run. The cron job must be removed from the charm before the job can be removed from the tree.
Revision history for this message
| Aaron Bentley (abentley) wrote | #1 |
To post a comment you must log in.
The idea at the time was that ingest would run this for new/modified charms and cstats would handle updates for unmodified charms.
https:/
Today, we run ingest against all charms, but I believe Kapil doesn't want that. He keeps saying that enqueue should query only for recently modified charms, which I take to mean that we should only ingest new/modified charms.
We need to decide whether we have a model where each charm is ingested every time, but some ingests are trivial (e.g. only updating download counts), or a model where ingest runs only against modified charms, and other scripts handle unmodified charms. cstats.py is currently redundant, but we need to decide whether the bug is in cstats or in the ingest process.