Bundle metadata contains redundant "doctype" attribute
Bug #1208477 reported by
Aaron Bentley
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
charmworld |
Fix Released
|
High
|
Aaron Bentley |
Bug Description
Charms and bundles have an attribute called "doctype" that is redundent with their Elasticsearch document type. For bundles, "doctype" and Elasticsearch document type are both set to "bundle". For charms, "doctype" and Elasticsearch document type are both set to "charm".
The Elasticsearch document type is needed because it allows separate mappings to be used for charms and bundles. Removing the redundancy therefore means removing the "doctype" attribute.
Related branches
lp:~abentley/charmworld/remove-doctype-attribute
- Curtis Hovey (community): Approve (code)
-
Diff: 151 lines (+0/-15)8 files modifiedcharmworld/jobs/lp.py (+0/-2)
charmworld/jobs/tests/test_lp.py (+0/-5)
charmworld/models.py (+0/-2)
charmworld/testing/factory.py (+0/-2)
charmworld/tests/test_models.py (+0/-1)
charmworld/tests/test_search.py (+0/-1)
charmworld/views/tests/test_api.py (+0/-1)
charmworld/views/tests/test_charms.py (+0/-1)
Changed in charmworld: | |
importance: | Undecided → High |
status: | New → Triaged |
Changed in charmworld: | |
assignee: | nobody → Aaron Bentley (abentley) |
status: | Triaged → In Progress |
Changed in charmworld: | |
status: | In Progress → Fix Committed |
Changed in charmworld: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.