Charmworld indexes far too many fields due to Elasticsearch dynamic mapping

[Aaron Bentley]

Dynamic mapping is Charmworld's default behaviour, but it hurts us because sometimes it gets the type wrong, and the ultimate mapping is gigantic (more than 400k pretty-printed).

The dynamic mappings give is no advantage because we don't search on those fields. We search on specific fields. It should be disabled.

[Curtis Hovey (sinzui)]

Work on this has stalled. The comments in charmworld.search indicate that the mapping can switch to static. I believe the blocking issue is bug 1194907.

[Abel Deuring (adeuring)]

On 16.09.2013 17:50, Curtis Hovey wrote:
> Work on this has stalled. The comments in charmworld.search indicate
> that the mapping can switch to static. I believe the blocking issue is
> bug 1194907.
>

I think r393 should have fixed the bug.

[Curtis Hovey (sinzui)]

I think bundles are dynamic. I see

        with translate_error():
            try:
                for (name, properties, dynamic) in (
                        (CHARM, charm_properties, False),
                        (BUNDLE, bundle_properties, True)):
                    self._client.put_mapping(self.index_name, name, {
                        name: {
                            'type': 'object',
                            'dynamic': dynamic,
                            'properties': properties,
                        }
                    })

I suspect that we can change bundled to dynamic=False, or remove the opportunity to accidentally pass dynamic=True:

        with translate_error():
            try:
                for (name, properties) in (
                        (CHARM, charm_properties,),
                        (BUNDLE, bundle_properties)):
                    self._client.put_mapping(self.index_name, name, {
                        name: {
                            'type': 'object',
                            'dynamic': False,
                            'properties': properties,
                        }
                    })

[Abel Deuring (adeuring)]

Right, bundles still have a dynamic mapping. Sorry I simply forgot about them when I wrote my last comment...