| 2013-06-26 15:01:03 |
Aaron Bentley |
description |
The list of files in the charm uses the filename, not the file-id, as a dictionary key. This means that collisions in filenames can cause masking, since the dictionary can have only one instance of a key. This is not currently a big problem, because only files in the hooks directory and specific files in the root directory are stored. Thus, the problem is only exhibited if files matching the following pattern exist:
"hooks/config.yaml", "hooks/metadata.yaml", "hooks/readme.*", "hooks/revision", "hooks/icon.svg"
If new file patterns are added in the future, the chance of a collision will increase slightly. If new directories are added, the chance of collision will increase dramatically. |
The list of files in the charm uses the filename, not the file-id, as a dictionary key. This means that collisions in filenames can cause masking, since the dictionary can have only one instance of a key. This is not currently a big problem, because only files in the hooks directory and specific files in the root directory are stored. Thus, the problem is only exhibited if files matching the following pattern exist:
"hooks/config.yaml", "hooks/metadata.yaml", "hooks/readme.*", "hooks/revision", "hooks/icon.svg"
If new file patterns are added in the future, the chance of a collision will increase slightly. If new directories are added, the chance of collision will increase dramatically.
When addressing this issue, it may make sense to address bug #1194907 at the same time. |
|
