tests need refactoring

[Charles Butler]

The python-moinmoin tests are failing consistently upon manual run with the following output:

charles@xps13:~/tmp/charms/precise/python-moinmoin$ charm test -e amazon
juju-test INFO : Starting test run on amazon using Juju 1.20.7
Launching instance
 - i-fa0aaa11
Waiting for address
Attempting to connect to ec2-54-160-140-200.compute-1.amazonaws.com:22
Attempting to connect to ip-10-6-98-35.ec2.internal:22
Attempting to connect to 54.160.140.200:22
Attempting to connect to 10.6.98.35:22
Logging to /var/log/cloud-init-output.log on remote host
Running apt-get update
Running apt-get upgrade
Installing package: git
Installing package: curl
Installing package: cpu-checker
Installing package: bridge-utils
Installing package: rsyslog-gnutls
Fetching tools: curl -sSfw 'tools from %{url_effective} downloaded: HTTP %{http_code}; time %{time_total}s; size %{size_download} bytes; speed %{speed_download} bytes/s ' --retry 10 -o $bin/tools.tar.gz 'https://juju-dist.s3.amazonaws.com/tools/releases/juju-1.20.7-trusty-amd64.tgz'
Bootstrapping Juju machine agent
Starting Juju machine agent (jujud-machine-0)
Added charm "cs:precise/python-moinmoin-3" to the environment.
ERROR charm not found: cs:trusty/haproxy
ERROR service "haproxy" not found
juju-test.conductor.01_deploy.test RESULT : ✘
Launching instance
 - i-d90faf32
Waiting for address
Attempting to connect to ec2-54-167-231-80.compute-1.amazonaws.com:22
Attempting to connect to ip-10-9-146-153.ec2.internal:22
Attempting to connect to 54.167.231.80:22
Attempting to connect to 10.9.146.153:22
Logging to /var/log/cloud-init-output.log on remote host
Running apt-get update
Running apt-get upgrade
Installing package: git
Installing package: curl
Installing package: cpu-checker
Installing package: bridge-utils
Installing package: rsyslog-gnutls
Fetching tools: curl -sSfw 'tools from %{url_effective} downloaded: HTTP %{http_code}; time %{time_total}s; size %{size_download} bytes; speed %{speed_download} bytes/s ' --retry 10 -o $bin/tools.tar.gz 'https://juju-dist.s3.amazonaws.com/tools/releases/juju-1.20.7-trusty-amd64.tgz'
Bootstrapping Juju machine agent
Starting Juju machine agent (jujud-machine-0)
Traceback (most recent call last):
  File "tests/get-unit-info", line 46, in <module>
    main()
  File "tests/get-unit-info", line 34, in main
    srv = d.get("services", {}).get(sys.argv[1])
IndexError: list index out of range
juju-test.conductor.get-unit-info RESULT : ✘
juju-test INFO : Results: 0 passed, 2 failed, 0 errored
charles@xps13:~/tmp/charms/precise/python-moinmoin$ ls

[Matt Bruzek (mbruzek)]

According to the latest test results by charm http://reports.vapour.ws/charm-tests-by-charm this charm is failing automated testing.

http://reports.vapour.ws/charm-tests/charm-bundle-test-930-results

The test looks to fail because '$datadir' is undefined. Please note it is OK to have bash tests, just make sure they pass and work as designed.

[Matt Bruzek (mbruzek)]

This bug was marked as an unmaintained charm per Unmaintained Charm Policy[0]. Per the process this bug was filled, email[1] sent to the community, and email sent to the maintainer. As there have been no updates this bug report, or merge proposals to bring this charm back into a working state this charm will be moved into the un-maintained namespace of the Charm Store. The charm will still be available in the Charm Store, but not under the recommended name space as it is failing deployment and Charm Policy[2]. Anyone can at anytime work on this charm, bring it back to passing Charm Policy[2], and resubmit[3] it as a recommended Charm.

[0] https://jujucharms.com/docs/charm-unmaintained-process
[1] https://lists.ubuntu.com/archives/juju/2014-December/004736.html
[2] https://jujucharms.com/docs/authors-charm-policy
[3] https://jujucharms.com/docs/authors-charm-store#submitting

[José Antonio Rey (jose)]

Hey Matt,

I have actually been working on these, but with some other critical bugs to fix (security) I've had to move this aside for a while. I didn't want to push any unfinished or bad code, hence the lack of updates. Expect a push + MP by early next week.

Sorry for any delays/inconveniences caused!