install does not check errors

[Clint Byrum]

Just had this happen:
2012-10-10 05:42:20,308: hook.output@INFO: Err http://ppa.launchpad.net/charmers/charm-helpers/ubuntu/ precise/main charm-helper-sh all 0.3+bzr164-3~precise1
2012-10-10 05:42:20,309: hook.output@INFO: Could not connect to ppa.launchpad.net:80 (91.189.95.83). - connect (110: Connection timed out)
2012-10-10 05:42:20,309: hook.output@INFO: Err http://ppa.launchpad.net/juju/pkgs/ubuntu/ precise/main charm-helper-sh all 0.3+bzr164-3~precise1
2012-10-10 05:42:20,311: hook.output@INFO: Failed to fetch http://ppa.launchpad.net/juju/pkgs/ubuntu/pool/main/c/charm-tools/charm-helper-sh_0.3+bzr164-3~precise1_all.deb Unable to connect to ppa.launchpad.net:http:
2012-10-10 05:42:20,324: hook.output@INFO: Fetched 57.5 MB in 1min 3s (910 kB/s)
2012-10-10 05:42:20,324: hook.output@INFO: E
2012-10-10 05:42:20,324: hook.output@INFO: :
2012-10-10 05:42:20,325: hook.output@INFO: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
2012-10-10 05:42:20,325: hook.output@INFO:
2012-10-10 05:41:24,929: hook.output@INFO: Get:74 http://us-west-2.ec2.archive.ubuntu.com/ubuntu/ precise/main sysstat amd64 10.0.3-1 [303 kB]

This should have made an error on install, but instead it merrily continued.. with more assumptions failing...

2012-10-10 05:42:23,799: unit.hook.api@INFO: Installing Nginx common config ...
2012-10-10 05:42:23,880: hook.output@INFO: install:
2012-10-10 05:42:23,880: hook.output@INFO: cannot create regular file `/etc/nginx/nginx.conf'
2012-10-10 05:42:23,880: hook.output@INFO: : No such file or directory
2012-10-10 05:42:23,881: hook.output@INFO:

2012-10-10 05:42:24,383: unit.hook.api@INFO: Installing Nginx actual site config ...
2012-10-10 05:42:24,434: hook.output@INFO: install:
2012-10-10 05:42:24,435: hook.output@INFO: cannot create regular file `/etc/nginx/sites-available/wordpress'
2012-10-10 05:42:24,435: hook.output@INFO: : No such file or directory
2012-10-10 05:42:24,435: hook.output@INFO:

This should have resulted in install-error, but instead we did not see a fail until start.

I believe the fix is a simple 'set -e' at the top of the script.

[Matthew Ruffell (mruffell)]

This bug has been fixed in the major maintenance performed on the wordpress charm, now known as cs:wordpress-0.

Install script now does a "set -e".

For more information, see Bug 1827164.