trusty/ubuntu charm: rev 9 broke Precise, Utopic, Vivid

[Ryan Beisner]

The Ubuntu charm fails to deploy Precise, Utopic and Vivid (even without enabling the new-lxc-network charm config option introduced at rev9).

Before rev9, deployments of this charm were successful to these supported releases.

Additionally, once the initial issues are resolved with these releases, use of the new-lxc-network charm config options results in an unreachable unit on Utopic, and additional errors on Precise.

It is important that the Ubuntu charm be kept functional on all currently-supported Ubuntu releases.

TLDR:

Vivid: python-yaml dependency issue. OK after that is resolved.

Utopic: lxc is not installed by default; and if it is installed ahead of the config-changed hook, use of the new-lxc-network option will cause a the unit to become unreachable following activation of the rendered template. http://paste.ubuntu.com/10935790/

Trusty: OK as-is.

Precise: python-six dependency issue, solved by a charm-helper sync. Once that is resolved, the issue then becomes no lxc or bridge-utils by default.

...

## Vivid: config-changed hook fails - ImportError: No module named yaml.
--> Python 2 dependency python-yaml can no longer be expected to be present in Vivid and later.

2015-04-23 15:14:07 INFO juju.worker.uniter.operation executor.go:87 preparing operation "run config-changed hook"
2015-04-23 15:14:07 DEBUG juju.worker.uniter.filter filter.go:627 discarded config event
2015-04-23 15:14:07 INFO juju.worker.uniter.operation executor.go:87 executing operation "run config-changed hook"
2015-04-23 15:14:07 INFO unit.ubuntu/0.config-changed logger.go:40 Traceback (most recent call last):
2015-04-23 15:14:07 INFO unit.ubuntu/0.config-changed logger.go:40 File "/var/lib/juju/agents/unit-ubuntu-0/charm/hooks/config-changed", line 12, in <module>
2015-04-23 15:14:07 INFO unit.ubuntu/0.config-changed logger.go:40 from charmhelpers.core.hookenv import (
2015-04-23 15:14:07 INFO unit.ubuntu/0.config-changed logger.go:40 File "/var/lib/juju/agents/unit-ubuntu-0/charm/hooks/charmhelpers/core/hookenv.py", line 25, in <module>
2015-04-23 15:14:07 INFO unit.ubuntu/0.config-changed logger.go:40 import yaml
2015-04-23 15:14:07 INFO unit.ubuntu/0.config-changed logger.go:40 ImportError: No module named yaml
2015-04-23 15:14:07 INFO juju.worker.uniter.context context.go:381 handling reboot
2015-04-23 15:14:07 ERROR juju.worker.uniter.operation runhook.go:89 hook "config-changed" failed: exit status 1
2015-04-23 15:14:07 INFO juju.worker.uniter modes.go:452 ModeAbide exiting
...

## Precise: ImportError: No module named six
--> This is fixed in charmhelpers. Sync needed.

2015-04-27 13:43:51 INFO unit.ubuntu/0.config-changed logger.go:40 Traceback (most recent call last):
2015-04-27 13:43:51 INFO unit.ubuntu/0.config-changed logger.go:40 File "/var/lib/juju/agents/unit-ubuntu-0/charm/hooks/config-changed", line 24, in <module>
2015-04-27 13:43:51 INFO unit.ubuntu/0.config-changed logger.go:40 from charmhelpers.core.hookenv import (
2015-04-27 13:43:51 INFO unit.ubuntu/0.config-changed logger.go:40 File "/var/lib/juju/agents/unit-ubuntu-0/charm/hooks/charmhelpers/core/hookenv.py", line 30, in <module>
2015-04-27 13:43:51 INFO unit.ubuntu/0.config-changed logger.go:40 import six
2015-04-27 13:43:51 INFO unit.ubuntu/0.config-changed logger.go:40 ImportError: No module named six
2015-04-27 13:43:51 ERROR juju.worker.uniter.operation runhook.go:89 hook "config-changed" failed: exit status 1

[Ryan Beisner (1chb1n)]

The proposed branch deployed OK for Precise, Trusty, Utopic and Vivid. Attaching corresponding jenkins artifacts and logs from these deployment checks.

[Ryan Beisner (1chb1n)]

While the proposed branch fixes the default functionality and deployability of the charm on Precise, Trusty, Utopic, and Vivid.

However, the design of the new-lxc-network config and its underlying hooks and templates only work on Trusty and Vivid. Using new-lxc-network on Utopic and Precise still fails.

[Ryan Beisner (1chb1n)]

Rather than attempt to ensure functionality of the added lxc feature for all releases, the Ubuntu charm should be reverted back to a charm with no hooks and no configuration options.

I'll propose that merge, along with added functional test coverage.

[Ryan Beisner (1chb1n)]

FYI, abandoned initial pass at solving the lxc option against all releases was @ lp:~1chb1n/charms/trusty/ubuntu/vivid-enablement.

[Ryan Beisner (1chb1n)]

Tested via bundletester / amulet on Precise, Trusty, Utopic, Vivid.

All passed.

Results: http://paste.ubuntu.com/10952530/