need relation webcontainer

[Philip Brown]

For best use, this should provide relation: webcontainer.

the code in "precise" has been changed to offer a good relation, codewise, but it uses langauge in reverse. It claims to
provide: webapp.

This is backwards.
Tomcat is a webcontainer, that uses (ie: requires) webapps.
So either the direction for the relation webapp should be reversed, or it should be kept as-is, but renamed webcontainer

[Matt Bruzek (mbruzek)]

Thank you for pointing out this problem. This issue was discussed at length on #juju

A merge proposal has been created to address the issues you had with the precise charm:

https://code.launchpad.net/~mbruzek/charms/precise/tomcat/trunk/+merge/284188

A merge proposal has been created to add the metadata to the trusty charm:

https://code.launchpad.net/~mbruzek/charms/trusty/tomcat/trunk/+merge/284189

[Kevin W Monroe (kwmonroe)]

Both precise and trusty charms have been merged. Thanks for the bug report and fix! Refreshed charms should be available from the store within an hour.

[Philip Brown (bolthole)]

I heard a rumor the code was tested.. but it was not.
The code is broken :(

Attempts to deploy yield this:
unit.tomcat/0.webapp-container-relation-joined logger.go:40 error: expected "key=value", got "webapp-path"

culprit:

webapp-container-relation-joined
relation-set webapp-path /var/lib/$VERSION/webapps

should have an '='

[Philip Brown (bolthole)]

PS I'm testing it with:
https://code.launchpad.net/~s-phil-s/charms/trusty/tomcat-webapp/trunk

[Matt Bruzek (mbruzek)]

We currently do not have a webapp that consumes this relationship. When you are ready submit your code as a merge proposal and it will be reviewed in the queue.

[Philip Brown (bolthole)]

I'm confused which code you are suggesting I submit as a merge proposal.

But anyways, just for the record, the charm that now uses this relationship is officially at

lp:~bolthole/charms/trusty/tomcat-webapp/trunk

[Kevin W Monroe (kwmonroe)]

Hey Philip, your tomcat-webapp charm will be the first to use this relation (which is part of the reason it wasn't caught on the first push). Thanks for identifying and pointing to the fix so quickly! MPs for this fix:

Precise:
https://code.launchpad.net/~bolthole/charms/precise/tomcat/trunk/+merge/284373

Trusty:
https://code.launchpad.net/~bolthole/charms/trusty/tomcat/trunk/+merge/284213

Both have been merged and updated charms should hit the store in about an hour. Marking this Fix Released.