workers == 0 meaning == cpu_count is broken

[James Westby]

From a deploy that has workers: 0 in the config:

grep workers /etc/swift/proxy-server.conf
workers = 0

This is because

 if workers == '0':
    import multiprocessing
    workers = multiprocessing.cpu_count()

when the config.yaml has

workers:
 default: 0
 type: int

so workers will be 0 not "0".

The check needs to be fixed to compare with the correct type.

Thanks,

James

[Tom Haddon (mthaddon)]

To be clear, with the default setting (workers: 0) we'd expect workers to be set to multiprocessing.cpu_count() rather than 0.