Promote to trusty

Bug #1355987 reported by Jorge Niedbalski on 2014-08-12
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rsyslog (Juju Charms Collection)
Undecided
Unassigned

Bug Description

- This charm has been tested on trusty, and can be migrated to the trusty branch.

Related branches

Charles Butler (lazypower) wrote :

Greetings Jorge,

I gave this charm a re-review and I came up with the following notes:

The README will need a thorough revamping. Ideally we like to see multiple sections such as deployment strategy with examples, covering the options in detail, upstream support locations to file bugs - to name a few. If you have charm-tools installed, execute `charm add readme` to generate a README.ex, and follow that format.

The make target for the tests i noticed installs a specific revision of python_apt from launchpad, and it failed for me locally. Removing that launchpad url and replacing it with python_apt worked a treat.

There is currently no Icon included for the service. If you need help generating an icon, it can be done in inkscape fairly quickly - and executing `charm add icon` will also generate a boilerplate SVG for you. https://juju.ubuntu.com/docs/authors-charm-icon.html is a great tutorial to get moving on creating a charm icon and the guidelines.

Barring the modifications requested above, you are very close to having the rsyslog charm prepared for Trusty inclusion. I'm going to move the status of this bug from NEW to INCOMPLETE. When you are ready for another review, simply move the status to FIX COMMITTED and someone will be along shortly to review your work.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http://askubuntu.com.

Changed in rsyslog (Juju Charms Collection):
status: New → Incomplete
Jorge Niedbalski (niedbalski) wrote :

OK @lazypower.

- Added a Readme.md markdown file.
- Added an icon.svg file
- Removed the python_apt package from test_requirements to just python_apt.

Please review merge/promote to trusty the linked branch.

Changed in rsyslog (Juju Charms Collection):
status: Incomplete → Fix Committed
Changed in rsyslog (Juju Charms Collection):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers