add-relation fails due to bug? in reviewboard

Bug #1361843 reported by Eric Snow on 2014-08-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Review Board
Unknown
Unknown
reviewboard (Juju Charms Collection)
Undecided
Unassigned

Bug Description

Using 1.20.5 on trusty I get errors after adding the DB relation for the reviewboard charm. The errors are due to what looks like a bug in reviewboard, but I'm not sure. (I'll file a report there separately and link it here.)

Basically in reviewboard.admin.support:get_support_url(), some of the values pulled from siteconfig are None, whereas str.join() only takes strings. I verified that falling back to empty strings in those cases resolved the issue.

In the meantime, I'm pretty sure the charm can work around this by providing --admin-email and --company in the rb-site install args in hooks.py:install_rb_site().

Eric Snow (ericsnowcurrently) wrote :

$ juju status
environment: local
machines:
  "0":
    agent-state: started
    agent-version: 1.20.5.1
    dns-name: localhost
    instance-id: localhost
    series: trusty
    state-server-member-status: has-vote
  "1":
    agent-state: started
    agent-version: 1.20.5.1
    dns-name: 10.0.3.118
    instance-id: esnow-local-machine-1
    series: trusty
    hardware: arch=amd64
  "2":
    agent-state: started
    agent-version: 1.20.5.1
    dns-name: 10.0.3.94
    instance-id: esnow-local-machine-2
    series: precise
    hardware: arch=amd64
services:
  postgresql:
    charm: cs:trusty/postgresql-3
    exposed: false
    relations:
      db:
      - reviewboard
      replication:
      - postgresql
    units:
      postgresql/0:
        agent-state: started
        agent-version: 1.20.5.1
        machine: "1"
        open-ports:
        - 5432/tcp
        public-address: 10.0.3.118
  reviewboard:
    charm: cs:precise/reviewboard-1
    exposed: false
    relations:
      db:
      - postgresql
    units:
      reviewboard/0:
        agent-state: error
        agent-state-info: 'hook failed: "db-relation-changed" for postgresql:db'
        agent-version: 1.20.5.1
        machine: "2"
        open-ports:
        - 80/tcp
        public-address: 10.0.3.94

Eric Snow (ericsnowcurrently) wrote :

Here's the charm's log file.

José Antonio Rey (jose) wrote :

Got the same behavior with 1.18 on EC2, running with all machines on precise.

Changed in reviewboard (Juju Charms Collection):
status: New → Confirmed
Eric Snow (ericsnowcurrently) wrote :

I've verified that add --admin-email and --company to the rb-site install args works around the problem.

Eric Snow (ericsnowcurrently) wrote :

FYI, the upstream bug has now been fixed (already!).

Adam Collard (adam-collard) wrote :

Incompatible changes in rb-site command line like this are prone to causing issues with the charm. This can be avoided by having (RB) version specific invocations, but that's something I'm hoping to avoid (maintenance nightmare).

Given upstream have acknowledged the issue, I'm tempted to turn this bug into a wishlist item for such a feature (e.g. juju set reviewboard version=2.0.4)

Eric Snow (ericsnowcurrently) wrote :

I like the idea of being able to specify your desired version of the plugin. (We discussed this on IRC.) It may make sense to hard-code the version in the charm to the last known working version (rather than using the latest). That would be a trivial change (I think).

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.