charm does not clean up

[Eric Snow]

From what I can tell the charm does not clean anything up when you run "juju remove-service reviewboard". I would expect anything added to postgres to be removed and likewise any files (e.g. /var/www/reviewboard, /etc/apache2/sites-*/reviewboard.conf). If I remove the service and then try deploying again I get various failures depending on the state of the previous deployment and whether or not the DB relation had been added.

This makes debugging reviewboard deployment issues a pain and could be a bigger problem if you have to re-use hosts or can't just blow away your DB and re-deploy.

[Eric Snow (ericsnowcurrently)]

Perhaps the stop hook needs to be expanded and db-relation-departed/-broken hooks added?

[David Britton (dpb)]

I think deleting data from postgres on removal is unexpected and potentially dangerous.

[José Antonio Rey (jose)]

Same here. I would expect it to have all my data once I relate psql back.

[Eric Snow (ericsnowcurrently)]

I agree that sometimes you want to keep the DB around. However, sometimes you do want a fresh DB, like when you remove and re-deploy to get a fresh reviewboard but you don't want to deploy a new postgres service. Both have merit. Could the charm accommodate both?

Regardless, the charm currently does not support using an existing reviewboard DB (rb-site can't handle it and the charm doesn't work around that).