charm does not clean up

Bug #1361822 reported by Eric Snow on 2014-08-26
This bug affects 1 person
Affects Status Importance Assigned to Milestone
reviewboard (Juju Charms Collection)

Bug Description

From what I can tell the charm does not clean anything up when you run "juju remove-service reviewboard". I would expect anything added to postgres to be removed and likewise any files (e.g. /var/www/reviewboard, /etc/apache2/sites-*/reviewboard.conf). If I remove the service and then try deploying again I get various failures depending on the state of the previous deployment and whether or not the DB relation had been added.

This makes debugging reviewboard deployment issues a pain and could be a bigger problem if you have to re-use hosts or can't just blow away your DB and re-deploy.

Eric Snow (ericsnowcurrently) wrote :

Perhaps the stop hook needs to be expanded and db-relation-departed/-broken hooks added?

Changed in reviewboard (Juju Charms Collection):
status: New → Triaged
Changed in reviewboard (Juju Charms Collection):
importance: Undecided → High
David Britton (davidpbritton) wrote :

I think deleting data from postgres on removal is unexpected and potentially dangerous.

José Antonio Rey (jose) wrote :

Same here. I would expect it to have all my data once I relate psql back.

Eric Snow (ericsnowcurrently) wrote :

I agree that sometimes you want to keep the DB around. However, sometimes you do want a fresh DB, like when you remove and re-deploy to get a fresh reviewboard but you don't want to deploy a new postgres service. Both have merit. Could the charm accommodate both?

Regardless, the charm currently does not support using an existing reviewboard DB (rb-site can't handle it and the charm doesn't work around that).

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers