nrpe charm creates checks with _sub postfix, breaking compatibility with nrpe-external-master

[JuanJo Ciarlante]

nrpe charm creates standard checks like e.g.:
command[check_disk_root_sub]=/usr/lib/nagios/plugins/check_disk -u GB -w 25% -c 20% -K 5% -p /

while n-e-m does:
command[check_disk_root]=/usr/lib/nagios/plugins/check_disk -u GB -w 25% -c 20% -K 5% -p /

, thus breaking nrpe <-> n-e-m compatibility.

[David Ames (thedac)]

I took a quick look at the previous nrpe version lp:charms/precise/nrpe and this behaviour did not exist. It appears to have been introduced with the re-write.

Liam can you comment on whether the '_sub' extension is required?

[Chris Stratford (chris-gondolin)]

Could the "_sub" extension at least be made optional?

[Chris Stratford (chris-gondolin)]

Proposed fix:

https://code.launchpad.net/~chris-gondolin/charms/trusty/nrpe/fix-sub-postfix/+merge/285692

[Barry Price (barryprice)]

I see Chris's merge above made it into the charm, but with a default setting of "_sub", none of our expected default check names exist on a fresh deploy.

I've proposed this MP to remove that default suffix - those who need it can obviously still set it wherever needed. But I'd really like to know the reasoning behind setting this default behaviour in the first place, as I may be missing something important here.

https://code.launchpad.net/~barryprice/nrpe-charm/+git/nrpe-charm/+merge/316532

[Liam Young (gnuoy)]

Checks can come from subordinates or user config I believe the sub prefix was used to differentiate them. However, it looks like this is now optional via the sub_postfix config option

[Paul Gear (paulgear)]

Marked won't fix for the charms collection branch, because it's deprecated in favour of lp:nrpe-charm