nova my_ip incorrectly formatted for ipv6

[Edward Hope-Morley]

With the following in my nova.conf (created by current Openstack charms in ipv6 mode):

mysq_ip=[2001:db8:1:0:f816:3eff:fe84:58dd]

which gives:

mysql> select host_ip from compute_nodes;
+------------------------------------+
| host_ip |
+------------------------------------+
| [2001:db8:1:0:f816:3eff:fe84:58dd] |
+------------------------------------+

But Nova does not like that:

2015-09-25 08:56:43.703 12988 TRACE nova.openstack.common.threadgroup File "/usr/lib/python2.7/dist-packages/nova/objects/fields.py", line 191, in coerce
2015-09-25 08:56:43.703 12988 TRACE nova.openstack.common.threadgroup return self._type.coerce(obj, attr, value)
2015-09-25 08:56:43.703 12988 TRACE nova.openstack.common.threadgroup
2015-09-25 08:56:43.703 12988 TRACE nova.openstack.common.threadgroup File "/usr/lib/python2.7/dist-packages/nova/objects/fields.py", line 340, in coerce
2015-09-25 08:56:43.703 12988 TRACE nova.openstack.common.threadgroup raise ValueError(six.text_type(e))
2015-09-25 08:56:43.703 12988 TRACE nova.openstack.common.threadgroup
2015-09-25 08:56:43.703 12988 TRACE nova.openstack.common.threadgroup ValueError: failed to detect a valid IP address from u'[2001:db8:1:0:f816:3eff:fe84:58dd]'

Removing the [] fixes the problem.

[Edward Hope-Morley (hopem)]

Ftr I hit this issue with Kilo.

[Edward Hope-Morley (hopem)]

...Icehouse works fine.

[Edward Hope-Morley (hopem)]

Bit more info, the error seems to be originating in nova-conductor - http://paste.ubuntu.com/12602538/. I've not tried Liberty yet but if the issue also exists there I will go with fixing this in Openstack since it feels like a regression.

[Edward Hope-Morley (hopem)]

OK, this is an Icehouse issue. Validation of the db host_ip field was introduced in Juno in commit [1] so in short, the fact that a formatted ipv6 address works in Icehouse is a false negative. We could backport [1] to Icehouse but as long as correctly formatted addresses are used for my_ip it is not a problem so for now I will just fix this in the nova-compute charm.

[1] https://github.com/openstack/nova/commit/40d2ed9667fe00d1766779cf670031e00e60d3ad