Polluted /tmp

[Ante Karamatić]

# cat /etc/init/os-charm-phy-nic-mtu.conf
description "Enabling Quantum external networking port"

start on runlevel [2345]

task

script
    devs=""
    mtu=""
    tmpfile=`mktemp`
    echo $devs > $tmpfile
    if [ -n "$mtu" ]; then
        while read -r dev; do
            [ -n "$dev" ] || continue
            rc=0
            # Try all devices before exiting with error
            ip link set $dev mtu $mtu || rc=$?
        done < $tmpfile
        rm $tmpfile
        [ $rc = 0 ] || exit $rc
    fi

that 'rm $tmpfile' will not get executed if mtu is "", which is default. Therefore one might end up with:

# ls -d /tmp/*
/tmp/tmp.8ngdiIzhoH /tmp/tmp.EZ8CYzPhJF /tmp/tmp.HJqViHHebh /tmp/tmp.T5IOEub64m /tmp/tmp.eC7wNcFgsP /tmp/tmp.oVoNeaDjxJ /tmp/tmp.tdZfCfNWBx /tmp/tmp.wi3ozzDhiW
/tmp/tmp.38ffc9CrI1 /tmp/tmp.AsTp6tCc6D /tmp/tmp.FLvTiBQzpc /tmp/tmp.M4RtpZyt1r /tmp/tmp.THZlVesrwc /tmp/tmp.igXSQZtyoY /tmp/tmp.reFNekHHzm /tmp/tmp.uUQkr44fup /tmp/tmp.yG1auwfmgU
/tmp/tmp.5TwWEYRhjj /tmp/tmp.BOvAnfIPXl /tmp/tmp.FeVP8RTavo /tmp/tmp.SteJ5gukJp /tmp/tmp.cTwB3DsBda /tmp/tmp.o1P9l3M6uv /tmp/tmp.rqSqzySsFw /tmp/tmp.wPtbr8I38O