The nagios charm fails automated testing

[Matt Bruzek]

In an effort to improve quality, we are testing all charms in an automated process.

According to the latest test results by charm http://reports.vapour.ws/charm-tests-by-charm this charm is failing automated testing.

The latest automated test results can be found here:
http://reports.vapour.ws/charm-tests/charm-bundle-test-4990-results

It looks like the 100-deploy test fails on all environments with the following output:

2014-11-04 04:42:41 The following units had errors:
   unit: nagios/0: machine: 3 agent-state: error details: hook failed: "install"

Please investigate and fix the charm or the test so the automated tests pass.

[Adam Israel (aisrael)]

I came across this while reviewing a MP for nagios and have some notes to add.

This is failing because the 100-deploy test is using precise as the default series, so the charm is being deployed to precise instead of trusty, and it depends on a package that wasn't available until trusty.

Changing the default series to trusty addresses the issue with nagios, but the test then fails with haproxy under trusty. Installing the precise version of haproxy succeeds, but then the test fails in the install hook of mysql (see https://bugs.launchpad.net/charms/+source/mysql/+bug/1408673).

[Matt Bruzek (mbruzek)]

I will take a look at this and fix this problem.

[Charles Butler (lazypower)]

In addition it appears the iterations post-facto have caused some additional issues. the monitors interface fails with the following trace:

ERROR: nagios::21-monitors-interface-test
[/tmp/bundletester-rGLciT/nagios/tests/21-monitors-interface-test exit 1]
2015-05-15 16:49:30 Starting deployment of amazon
2015-05-15 16:49:31 Deploying services...
2015-05-15 16:49:32 Deploying service mediawiki using cs:trusty/mediawiki-3
2015-05-15 16:49:39 Deploying service mysql using cs:trusty/mysql-25
2015-05-15 16:49:49 Deploying service nagios using local:trusty/nagios
2015-05-15 16:50:00 Deploying service nrpe using cs:trusty/nrpe-3
2015-05-15 16:50:08 Config specifies num units for subordinate: nrpe
2015-05-15 16:56:47 Adding relations...
2015-05-15 16:56:48 Adding relation mysql:db <-> mediawiki:db
2015-05-15 16:56:48 Adding relation nagios:monitors <-> mysql:monitors
2015-05-15 16:56:48 Adding relation nrpe:general-info <-> mysql:juju-info
2015-05-15 16:56:49 Adding relation nrpe:monitors <-> nagios:monitors
2015-05-15 16:56:49 Adding relation nrpe:local-monitors <-> mysql:local-monitors
2015-05-15 16:59:07 Exposing service 'nagios'
2015-05-15 16:59:07 Deployment complete in 576.87 seconds
Traceback (most recent call last):
  File "/tmp/bundletester-rGLciT/nagios/tests/21-monitors-interface-test", line 42, in test_nrpe_monitors_config
    mysql_unit.file_contents('/etc/nagios/nrpe.d/procrunning_mysqld.cfg')
  File "/usr/lib/python3/dist-packages/amulet/sentry.py", line 85, in file_contents
    raise IOError(output)
OSError: cat: /etc/nagios/nrpe.d/procrunning_mysqld.cfg: No such file or directory
ERROR subprocess encountered error code 1

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/tmp/bundletester-rGLciT/nagios/tests/21-monitors-interface-test", line 61, in <module>
    test_nrpe_monitors_config()
  File "/tmp/bundletester-rGLciT/nagios/tests/21-monitors-interface-test", line 44, in test_nrpe_monitors_config
    amulet.raise_status(amulet.ERROR,
AttributeError: 'module' object has no attribute 'ERROR'

[Cory Johns (johnsca)]

Still getting test failures on this charm, and since the link to the test results in the original description is dead, here is a permanent link to the results I just got: http://pastebin.ubuntu.com/12717395/