guiserver reports second bundle as failing after the first fails
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| juju-deployer |
Fix Released
|
Undecided
|
Francesco Banconi | ||
| juju-gui (Juju Charms Collection) |
Fix Released
|
High
|
Francesco Banconi | ||
Bug Description
When QA'ing the UI notices to the user it was brought up that if you schedule two bundles in a row, when the first fails, it will report the second as an error as well even though it continues and succeeds.
Steps to reproduce (in lxc or ec2)
Deploy the gui
Deploy the discource bundle[1]
Deploy the jenkins bundle[2]
Wait for the discourse bundle to error out (20+min)
Notice the failure message for the discourse deployment
Then the jenkins deployment will be reported as in Error as well.
The jenkins deployment continues on and completes without any further notifications.
In tracing the websocket frames, the Error field was empty and it was in fact for both deployment ids 0 and 1.
[1] https:/
[2] https:/
Related branches
- Brad Crittenden (community): Approve (code)
- juju-deployers: Pending requested
-
Diff: 903 lines (+462/-170)12 files modifieddeployer/action/importer.py (+23/-16)
deployer/cli.py (+4/-0)
deployer/deployment.py (+4/-0)
deployer/env/go.py (+44/-56)
deployer/env/mem.py (+1/-2)
deployer/env/py.py (+20/-14)
deployer/env/watchers.py (+110/-0)
deployer/guiserver.py (+8/-0)
deployer/tests/test_deployment.py (+8/-0)
deployer/tests/test_guiserver.py (+48/-32)
deployer/tests/test_pyenv.py (+46/-50)
deployer/tests/test_watchers.py (+146/-0)
- Marco Ceppi (community): Abstain
- Juju GUI Hackers: Pending requested
-
Diff: 77 lines (+9/-8)3 files modifiedserver-requirements.pip (+1/-1)
server/guiserver/bundles/base.py (+4/-4)
server/guiserver/tests/bundles/test_base.py (+4/-3)
| Francesco Banconi (frankban) wrote | #1 |
| Kapil Thangavelu (hazmat) wrote | #2 |
| Antonio Rosales (arosales) wrote | #3 |
| Jorge Castro (jorge) wrote | #4 |
| Changed in juju-deployer: | |
| status: | New → In Progress |
| Changed in juju-gui (Juju Charms Collection): | |
| status: | Triaged → In Progress |
| assignee: | nobody → Francesco Banconi (frankban) |
| Changed in juju-deployer: | |
| assignee: | nobody → Francesco Banconi (frankban) |
| Changed in juju-deployer: | |
| milestone: | none → 0.3.2 |
| Changed in juju-deployer: | |
| status: | In Progress → Fix Released |
| Changed in juju-gui (Juju Charms Collection): | |
| status: | In Progress → Fix Committed |
| Changed in juju-gui (Juju Charms Collection): | |
| status: | Fix Committed → Fix Released |
The deployer does not allow bundle deployments if a unit in the environment is in an error state.
In this case, an exception without a message is returned by the deployer, and that's why the error field was empty: now it should be "no further details available" or similar.