nagios_context must match related nrpe nagios_host_context

[Michael Nelson]

Not sure if this is a bug or intended, but I assumed by setting the nagios_context on the haproxy charm, that it would take precedence over that defined in the related nrpe_external_master's nagios_host_context.

Turns out it only half does, leading to a broken configuration, because the haproxy charm (well, charmhelper's) write the service__ configs correctly using the haproxy nagios_context value, while the nrpe_external_master subordinate wirtes the host__ config file, using its own value.

[Michael Nelson (michael.nelson)]

The inconsistency seems to be fixed by a newer version of charmhelpers than in used in this charm, which uses the hostname from the nrpe subordinate if it's defined, before defaulting to that used in the charm config:

See

http://bazaar.launchpad.net/~charm-helpers/charm-helpers/devel/view/head:/charmhelpers/contrib/charmsupport/nrpe.py#L301