Elasticsearch charm needs Xenial support

Bug #1657713 reported by Peter Sabaini
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
elasticsearch (Juju Charms Collection)
Undecided
Unassigned

Bug Description

Currently as per https://jujucharms.com/elasticsearch/ this charm only supports trusty. We'd need support for the current LTS, xenial

Version info: cs:trusty/elasticsearch-19

Related branches

description: updated
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Good timing :) I was just independently wanting to investigate how easy it would be to support xenial in the current charm which we use in online-services (which is not quite the charmstore version - see the linked merge-proposal for more info).

If you do get a chance, please test my branch at:

https://code.launchpad.net/~michael.nelson/charms/trusty/elasticsearch/elasticsearch2-with-xenial-support/+merge/315196

Thanks

Revision history for this message
James Hebden (ec0) wrote :

Hey Michael, testing this out and it seems the are some issues installing from the ES APT repositories (they don't seem to provide a Release file). It's a fairly common issue from experience and a bit of research.

I've noticed in the past that most tools installing ES (the puppet module, for example) actually go out to the debs directly instead of using APT. I've made a branch that does just that. Downside is obviously that automated updates via apt-get upgrade won't work, but bumping the 'version' config in juju should kick off an upgrade.

I've made changes based on your branch and pushed them to https://code.launchpad.net/~jhebden/charms/trusty/elasticsearch/elasticsearch2-xenial-direct-download
I've linked that branch to this bug as well, but if you're happy with the changes, feel free to merge them into yours and we can unlink my branch to prevent confusion.

Work is still needed to fix the dns / dig ansible module or rework the relation change module, but I'd be interested in your initial feedback.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hi James,

Thanks for the branch! Note, you probably saw that the charm currently supports two methods - apt or you can put whatever deb you want in files/elasticsearch.deb (which will be preferred if present).

I don't think we can remove the apt functionality - at least, we use it with internal repositories for provisioning ES when we deploy. The fact that the default values for the elastico repo are now broken is news to me. Checking:

https://www.elastic.co/guide/en/elasticsearch/reference/current/deb.html#deb-repo

it looks like there was an issue with older versions of add-apt-repository, but that issue is not present on xenial. In fact, I've just checked on a xenial lxc and don't see any issues with the repo itself:

http://paste.ubuntu.com/23963282/

Can you paste what you see (or test in the instance)?

As to your second rev, +100 to remove the custom plugin etc.
Thanks!

Revision history for this message
James Hebden (ec0) wrote :

Hi Michael,

Thanks for guidance on these changes. I've found that the 403 issues I were seeing were environment, due to https://bugs.launchpad.net/maas/+bug/1300266. I've re-instated the apt repo functionality on my branch, in a way that still allows for a deb to be downloaded and installed based on version - figure this is more desirable than dropping an ES deb, given they're huge, and it's easier to keep a version number in version control.

I've also modified the relation hooks to no longer need the dns/dig modules.
/_cluster/health output from a 3 node cluster launched using juju2+lxd+xenial+mojo - http://pastebin.ubuntu.com/23965275/

Revision history for this message
Tom Haddon (mthaddon) wrote :

Note that there is now https://jujucharms.com/u/elasticsearch-charmers/elasticsearch/ which supports trusty and xenial.

Revision history for this message
Alvaro Uria (aluria) wrote :

Since the link from the bug description points to the charm Tom mentioned, which already supports xenial and bionic, I'm going to go ahead and mark this bug as fix released.

Changed in elasticsearch (Juju Charms Collection):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers