charm upgrade from 16.07 to master fails

[Ryan Beisner]

Charm upgrade fails from the 16.07 ceph charm version to the next/master ceph charm version https://github.com/openstack/charm-ceph/commit/3a845f6f892d3e09b64ba3741d0fcd8a8190bbc6.

2016-09-27 22:00:20 INFO upgrade-charm Traceback (most recent call last):
2016-09-27 22:00:20 INFO upgrade-charm File "/var/lib/juju/agents/unit-ceph-0/charm/hooks/upgrade-charm", line 22, in <module>
2016-09-27 22:00:20 INFO upgrade-charm from ceph.ceph_broker import (
2016-09-27 22:00:20 INFO upgrade-charm ImportError: No module named ceph_broker

[Chris MacNaughton (chris.macnaughton)]

So, this seems to be happily resolved by running: 'rm -rf **/*.pyc'. It looks like python is using the cached version instead of noticing the change and, in the cached version, there's no such thing as ceph.ceph_broker

[Ryan Beisner (1chb1n)]

https://review.openstack.org/#/c/378758/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/381252

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/381252
Committed: https://git.openstack.org/cgit/openstack/charm-ceph/commit/?id=a62a1e5adbef470c07a869a98e9139881a6d226a
Submitter: Jenkins
Branch: master

commit a62a1e5adbef470c07a869a98e9139881a6d226a
Author: Chris MacNaughton <email address hidden>
Date: Mon Oct 3 13:14:04 2016 -0400

    Remove the compiled python bytecode

    upgrade-charm could previously fail because of compiled bytecode
    remaining behind. This change makes the upgrade-charm hook remove
    any such compiled bytecode files

    Change-Id: I1cb6521cab1ac0d529907d44f1e9bdb313a798ac
    Closes-Bug: 1628322

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/381253
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-osd/commit/?id=0dd383d35134bea7b4146fd8277b22ab5d27c2ac
Submitter: Jenkins
Branch: master

commit 0dd383d35134bea7b4146fd8277b22ab5d27c2ac
Author: Chris MacNaughton <email address hidden>
Date: Mon Oct 3 13:16:30 2016 -0400

    Remove the compiled python bytecode

    upgrade-charm could previously fail because of compiled
    bytecode remaining behind. This change makes the upgrade-charm
    hook remove any such compiled bytecode files

    Closes-Bug: 1628322

    Change-Id: I3886b514b47d6fc9fdfb350e2b3a2296472e40f6