ceph charms error on rgw relation

[Edward Hope-Morley]

All the ceph charms recently received an update tjhat breaks the radosgw relation due to required args not being provided to ceph.get_radosgw_key():

ceph/hooks/ceph_hooks.py: 'radosgw_key': ceph.get_radosgw_key(),
ceph/lib/ceph/__init__.py:def get_radosgw_key(pool_list):
ceph-mon/hooks/ceph_hooks.py: 'radosgw_key': ceph.get_radosgw_key(),
ceph-mon/lib/ceph/__init__.py:def get_radosgw_key(pool_list):
ceph-osd/lib/ceph/__init__.py:def get_radosgw_key(pool_list):
ceph-radosgw/hooks/ceph.py:def get_radosgw_key():

Error is like:

2016-09-26 11:27:34 INFO radosgw-relation-joined Traceback (most recent call last):
2016-09-26 11:27:34 INFO radosgw-relation-joined File "/var/lib/juju/agents/unit-ceph-0/charm/hooks/radosgw-relation-joined", line 606, in <module>
2016-09-26 11:27:34 INFO radosgw-relation-joined hooks.execute(sys.argv)
2016-09-26 11:27:34 INFO radosgw-relation-joined File "/var/lib/juju/agents/unit-ceph-0/charm/hooks/charmhelpers/core/hookenv.py", line 715, in execute
2016-09-26 11:27:34 INFO radosgw-relation-joined self._hooks[hook_name]()
2016-09-26 11:27:34 INFO radosgw-relation-joined File "/var/lib/juju/agents/unit-ceph-0/charm/hooks/radosgw-relation-joined", line 441, in radosgw_relation
2016-09-26 11:27:34 INFO radosgw-relation-joined 'radosgw_key': ceph.get_radosgw_key(),
2016-09-26 11:27:34 INFO radosgw-relation-joined TypeError: get_radosgw_key() takes exactly 1 argument (0 given)

NOTE: This issue is only the current master (development) branches.

[Edward Hope-Morley (hopem)]

Looks like these commits cause the regression:

https://github.com/openstack/charm-ceph/commit/57808f02ab544d5f63a4c52a4bee8238d3fdb3e1
https://github.com/openstack/charm-ceph-osd/commit/801f8538fc8d61d3f85e73a8847d351fe84e7655
https://github.com/openstack/charm-ceph-mon/commit/e5306f1e321ed43153adec9c0035f8e9888b466b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/376456

[Edward Hope-Morley (hopem)]

Fix proposed to branch: master
Review: https://review.openstack.org/376459

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/376459
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-mon/commit/?id=8b5350e3b4b2a55df3b0e01011203d1678cb98c7
Submitter: Jenkins
Branch: master

commit 8b5350e3b4b2a55df3b0e01011203d1678cb98c7
Author: Edward Hope-Morley <email address hidden>
Date: Mon Sep 26 14:01:54 2016 +0100

    Fix radosgw relation broken by commit e5306f1

    Change-Id: Ia21a5eb9238e0d731a603911f77c69e13af35c8a
    Closes-Bug: 1627718

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/376456
Committed: https://git.openstack.org/cgit/openstack/charm-ceph/commit/?id=3a845f6f892d3e09b64ba3741d0fcd8a8190bbc6
Submitter: Jenkins
Branch: master

commit 3a845f6f892d3e09b64ba3741d0fcd8a8190bbc6
Author: Edward Hope-Morley <email address hidden>
Date: Mon Sep 26 13:59:12 2016 +0100

    Fix radosgw relation broken by commit 57808f0

    Change-Id: I146fe1fe15515dbb90cd8f77d5ecaff4851bcb26
    Closes-Bug: 1627718