ceph resource creation should be moved to the ceph charm
Bug #1390939 reported by
Edward Hope-Morley
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ceph (Juju Charms Collection) |
Fix Released
|
Medium
|
Edward Hope-Morley | ||
Bug Description
Currently, when a ceph-client relation e.g. cinder, is joined to ceph, it is responsible for performing actions like creating pools. Performing these actions on the client side increases code complexity and increases chances of race conditions. This can easily be improved by having clients request such resources be having the ceph charm act as a broker for such requests.
Using this approach we can also make some effort to protect against ceph clients creating resources before the cluster is ready e.g. pool create configurations are proportional to the number of OSDs up+in the cluster at create time so we can have the ceph charm check that all known OSDs are UP and IN before creating pools.
Related branches
lp:~hopem/charms/trusty/ceph/ceph-broker
- James Page: Pending requested
-
Diff: 750 lines (+593/-17)10 files modifiedMakefile (+5/-1)
charm-helpers-hooks.yaml (+1/-0)
hooks/ceph_broker.py (+90/-0)
hooks/charmhelpers/contrib/network/ip.py (+0/-2)
hooks/charmhelpers/contrib/storage/linux/ceph.py (+388/-0)
hooks/charmhelpers/core/services/__init__.py (+2/-2)
hooks/charmhelpers/fetch/__init__.py (+1/-1)
hooks/hooks.py (+32/-11)
unit_tests/__init__.py (+2/-0)
unit_tests/test_ceph_broker.py (+72/-0)
lp:~hopem/charms/trusty/cinder/ceph-broker
- James Page: Needs Resubmitting
-
Diff: 330 lines (+130/-50)6 files modifiedhooks/charmhelpers/contrib/storage/linux/ceph.py (+43/-0)
hooks/cinder_hooks.py (+36/-15)
hooks/cinder_utils.py (+0/-12)
unit_tests/test_cinder_hooks.py (+51/-7)
unit_tests/test_cinder_utils.py (+0/-14)
unit_tests/test_cluster_hooks.py (+0/-2)
lp:~hopem/charms/trusty/glance/ceph-broker
- OpenStack Charmers: Pending requested
-
Diff: 253 lines (+113/-32)3 files modifiedhooks/charmhelpers/contrib/storage/linux/ceph.py (+43/-0)
hooks/glance_relations.py (+42/-27)
unit_tests/test_glance_relations.py (+28/-5)
| affects: | charms → ceph (Juju Charms Collection) |
| Changed in ceph (Juju Charms Collection): | |
| status: | In Progress → Fix Committed |
| tags: | added: cts openstack |
| Changed in ceph (Juju Charms Collection): | |
| milestone: | none → 15.01 |
| Changed in ceph (Juju Charms Collection): | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Marco Ceppi (marcoceppi) wrote | #1 |
To post a comment you must log in.
.