block-storage-broker on Trusty + OpenStack fails in install

[Jason Robinson]

Tried to deploy block-storage-broker (trusty) on an OpenStack machine, it failed to install with the following error:

unit-block-storage-broker-0: 2014-07-29 19:56:52 INFO install File "/var/lib/juju/agents/unit-block-storage-broker-0/charm/hooks/charmhelpers/core/hookenv.py", line 381, in execute
unit-block-storage-broker-0: 2014-07-29 19:56:52 INFO install self._hooks[hook_name]()
unit-block-storage-broker-0: 2014-07-29 19:56:52 INFO install File "/var/lib/juju/agents/unit-block-storage-broker-0/charm/hooks/install", line 86, in install
unit-block-storage-broker-0: 2014-07-29 19:56:52 INFO install fetch.add_source("cloud-archive:havana")
unit-block-storage-broker-0: 2014-07-29 19:56:52 INFO install File "/var/lib/juju/agents/unit-block-storage-broker-0/charm/hooks/charmhelpers/fetch/__init__.py", line 142, in add_source
unit-block-storage-broker-0: 2014-07-29 19:56:52 INFO install subprocess.check_call(['add-apt-repository', '--yes', source])
unit-block-storage-broker-0: 2014-07-29 19:56:52 INFO install File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
unit-block-storage-broker-0: 2014-07-29 19:56:52 INFO install raise CalledProcessError(retcode, cmd)
unit-block-storage-broker-0: 2014-07-29 19:56:52 INFO install subprocess.CalledProcessError: Command '['add-apt-repository', '--yes', 'cloud-archive:havana']' returned non-zero exit status 1
unit-block-storage-broker-0: 2014-07-29 19:56:52 ERROR juju.worker.uniter uniter.go:486 hook failed: exit status 1

Doing this manually shows what causes it:

    ubuntu@juju-cloudvps-machine-0:~$ sudo add-apt-repository --yes cloud-archive:havana
    cloud-archive only supported on precise

How can we add Trusty support for the broker? Willing to do a patch if I know what to do :)

[Jason Robinson (jaywink)]

OK seems the code for trusty just isn't up to date with the last commit. It seems this has been fixed in revision 53, but only in the precise branch.

To me it seems the whole charm is missing an official branch for trusty in launchpad? https://code.launchpad.net/charms/trusty/+source/block-storage-broker

For precise there is one: https://code.launchpad.net/~charmers/charms/precise/block-storage-broker/trunk

I checked the review queue and found nothing related to this. Can I just link a branch here, with the latest rev 53 commit and then get it to the review queue?

[Chad Smith (chad.smith)]

Jason, my apologies for the tardiness in tracking this bug/feature request. As you surmised, the original charm was not developed with trusty support. That support will be added per bug lp:1358546 and should be reviewed and landed in short order.

[Chad Smith (chad.smith)]

Will put up a branch to use charmhelpers.contrib.openstack.config_installation_source which is openstack-charmers best practice for setting up openstack repositories.