zentyal

[Christophe Sauthier]

Creation of the zentyal charm

[Marc Cluet (lynxman)]

Hi Christophe,

Thank you very much for your submission! Here's some notes after reviewing the charm

- At install hook

ExternalMASQ=$(ifconfig | grep $ExternalIP | cut -f16 -d ' ' | cut -f2 -d':')
You could use "ip addr list" instead of ifconfig, it'll work better for you

add-apt-repository ppa:zentyal/2.3
It'll require a confirmation (this is new in precise) you can do so by changing this line to add-apt-repository -y ppa:zentyal/2.3

Apart form that please don't forget to add the maintainer: field in metadata.yaml

Please change the state back to new so it can be reviewed again.

[Clint Byrum (clint-fewbar)]

Excerpts from Marc Cluet's message of 2012-06-07 16:52:01 UTC:
> Hi Christophe,
>
> Thank you very much for your submission! Here's some notes after
> reviewing the charm
>
> - At install hook
>
> ExternalMASQ=$(ifconfig | grep $ExternalIP | cut -f16 -d ' ' | cut -f2 -d':')
> You could use "ip addr list" instead of ifconfig, it'll work better for you
>

Actually you should probably use 'unit-get private-address' ... the box
could have many interfaces and such, but you almost always want to be
using the address that juju is aware of.