Charm needed: Shelr.tv

[Marco Ceppi]

http://shelr.tv is a cool terminal casting program, both the web and client are open source.

[Marco Ceppi (marcoceppi)]

Ready for review!

[Mark Mims (mark-mims)]

Looks great... promulgate.

my comments:

- why the git update-index? is this really necessary?

- I doubt there's a need to run everything as root... bundle install and bundle exec could be done as some other user. I'm not sure the real utility of daemon users on dedicated instances, maybe running as root will become the norm. Just noticing

- dangling mongodb-relation-changed, even though you're using db-relation-changed

awesome!

[Marco Ceppi (marcoceppi)]

> - why the git update-index? is this really necessary?

If during charm-upgrade git pull updates the default mongoid.yml file, our db relation will be lost

> - I doubt there's a need to run everything as root... bundle install and bundle exec could be done as some other user. I'm not sure the real utility of daemon users on dedicated instances, maybe running as root will become the norm. Just noticing

This might be true, in my experience bundle install installs the gems to /var/lib/ruby... so sudo is needed, as for the exec not sure, I'll have to test that

> - dangling mongodb-relation-changed, even though you're using db-relation-changed

Removed

---

And Promulgated!