Charm needed: Firefox Sync

[Jorge Castro]

A nice charm for your own hosted Ubuntu Firefox Sync server is a nice companion for our default browser:

https://wiki.mozilla.org/Services/Sync/Server
http://docs.services.mozilla.com/howtos/run-sync.html

[Ben Howard (darkmuggle-deactivatedaccount)]

Claiming this. I have this nearly working.

[Ben Howard (darkmuggle-deactivatedaccount)]

Linked new branch for review.

[Mark Mims (mark-mims)]

note to rename fsync to firefox-sync before pushing any official branches

[Robert Ayres (robert-ayres)]

Thanks for submitting the charm, worked well on EC2.

Please see bugs/comments below.

Bugs
*hooks/common.sh, looks like a typo within build_source when removing old build directory '${buildd}' instead of '${build_d}'.

*hooks/website-relation-joined, doesn't set 'hostname' or 'port'.

*/usr/local/sync_server/sync.db and /usr/local/sync_server/server-full/etc/sync.conf are world readable but may contain sensitive information.

Comments
*It'd be nice if the daemon ran as a different user than root.

*cache relation has hooks but no definition in metadata.yaml.

*Be quite nice if you could toggle 'allow_new_users' in sync.conf to enable/restrict new user creation via a config option.

Please fix the bugs and consider the comments then resubmit for a second review.

[Ben Howard (darkmuggle-deactivatedaccount)]

*hooks/common.sh, looks like a typo within build_source when removing old build directory '${buildd}' instead of '${build_d}'.
--- Fixed

*hooks/website-relation-joined, doesn't set 'hostname' or 'port'
--- Fixed.

*world readable files:
--- Fixed.

*It'd be nice if the daemon ran as a different user than root.
--- Introduced code to create and run as firefox-sync user

*cache relation has hooks but no definition in metadata.yaml
--- Removed as artfact

*Be quite nice if you could toggle 'allow_new_users' in sync.conf to
enable/restrict new user creation via a config option.
-- Implemented

[Marco Ceppi (marcoceppi)]

Hi Ben!

Thanks for making those changes, the charm is really coming together!

The only issue I have at the moment is I can't seem to get Firefox to actually accept the server when I attempted to test the sync[1]. It's possible I did something wrong which leads to my next point, the README is a tad out of date, the charm name needs to be updated as it uses the fsync name. I'd also like to see a section on how to actually use the service within firefox as I can't seem to get it working.

A few knitpicks:

There's a configuration option for db_sqlite which is redundant. It should just use sqlite unless there's a MySQL relation (which is pretty much what happens currently).

Baring actually verifying it works with Firefox and an updated readme this charm looks good to me. Great job!

[Ben Howard (darkmuggle-deactivatedaccount)]

Fixed the read me. Removed nit-pick on sqlite.

Confirmed that it works. I suspect that the issue is with using the wrong port.

[Marco Ceppi (marcoceppi)]

Commenting to drop from the review queue