Gitolite charm
Bug #906176 reported by
Chris Hardee
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Juju Charms Collection |
Incomplete
|
Wishlist
|
Marco Ceppi |
Bug Description
lp:~shazzner/charm/oneiric/gitolite/trunk
Initial working charm for Gitolite, has limited functionality at the moment but can create repositories and administer users.
Provides a server interface: gitolite
Related branches
Changed in charms: | |
importance: | Undecided → Wishlist |
assignee: | nobody → shazzner (shazzner) |
Changed in charms: | |
assignee: | shazzner (shazzner) → nobody |
Changed in charms: | |
assignee: | nobody → Marco Ceppi (marcoceppi) |
Changed in charms: | |
status: | Incomplete → Fix Committed |
tags: | removed: new-charm |
To post a comment you must log in.
Thanks a lot for this new charm, it's a great idea!
I am not an "official" reviewer, but here are a few remarks from my point of view:
[1] shared fs backend:
due to the ephemeral nature of instances, it might make sense to propose to use a shared file systems where the git repository are stored. I would suggest, to use a ceph or nfs relation to share the files (charms already exist for both). This would also allow to use "add-unit" to increase the number of unit while publishing the same repositority, which is the whole point of juju, IMHO. It also would prevent from loosing all the repo if the instance this is running on was to die.
[2] readme:
It is a good practice (not a requirement) to place a readme file in the charm's directory to explain how to use your charm, give caveats, examples etc...
[3] chmod 777 "$KEY_FILE"
are you sure you want to make your key read/write/execute to the world? 660 would seem more appropriate.
[4] config-changed hook
it would be nice to implement config-changed event to allow for a change of the keys
[5] start/stop hook
need to be implemented. A simple 'service <service-name> [restart|stop] is generally enough.
Thanks again for your work. This is only my 2 cents review as a community charmer.